Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7019ed3e authored by Kelvin Kwan's avatar Kelvin Kwan
Browse files

Fix broken test on UserIdMangerTest 

Test: atest DocumentsUIGoogleTests:com.android.documentsui.UserIdManagerTest
Bug: 150214958
Bug: 150108105
Change-Id: I88f2b9c8a1afdae657f821e13a221dc1fbad4c9a
parent 4505a178

src/com/android/documentsui/UserIdManager.java

+1 −2
Original line number Diff line number Diff line
@@ -34,7 +34,6 @@ import android.util.Log; 
import androidx.annotation.GuardedBy;

import androidx.annotation.Nullable;

import androidx.annotation.VisibleForTesting;

import androidx.core.os.BuildCompat;



import com.android.documentsui.base.Features;

import com.android.documentsui.base.UserId;
@@ -214,7 +213,7 @@ public interface UserIdManager { 
        private static boolean isDeviceSupported(Context context) {

            // The feature requires Android R DocumentsContract APIs and INTERACT_ACROSS_USERS

            // permission.

            return (BuildCompat.isAtLeastR()

            return (Build.VERSION.CODENAME.equals("R")

                    || (Build.VERSION.CODENAME.equals("REL") && Build.VERSION.SDK_INT >= 30))

                    && context.checkSelfPermission(Manifest.permission.INTERACT_ACROSS_USERS)

                    == PackageManager.PERMISSION_GRANTED;

tests/unit/com/android/documentsui/UserIdManagerTest.java

+1 −2
Original line number Diff line number Diff line
@@ -28,7 +28,6 @@ import android.os.Build; 
import android.os.UserHandle;

import android.os.UserManager;



import androidx.core.os.BuildCompat;

import androidx.test.filters.SmallTest;



import com.android.documentsui.base.UserId;
@@ -141,7 +140,7 @@ public class UserIdManagerTest { 
    @Test

    public void testGetUserIds_deviceWithoutPermission() {

        // This test only tests for Android R or later. This test case always passes before R.

        if (BuildCompat.isAtLeastR()

        if (Build.VERSION.CODENAME.equals("R")

                || (Build.VERSION.CODENAME.equals("REL") && Build.VERSION.SDK_INT >= 30)) {

            // When permission is denied, only returns the current user.

            when(mockContext.checkSelfPermission(Manifest.permission.INTERACT_ACROSS_USERS))