Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b72eef0 authored by Wenbo Jie's avatar Wenbo Jie
Browse files

[DocsUI M3] Add a string for "clear selection" 

When files are selected, we will show a close button on the app
bar to clear selection, previously the content description for
this button is "Cancel", this CL creates a new string with
"Clear selection" to make it more explicit.

Bug: 408898634
Test: m DocumentsUIGoogle && manual inspection
Flag: com.android.documentsui.flags.use_material3
Change-Id: I17e7cd4b06729a1207178e6af0e30b2c503ef9fb
parent 867b243b

res/values/strings.xml

+2 −0
Original line number Diff line number Diff line
@@ -470,6 +470,8 @@ 
        <item quantity="one"><xliff:g id="count" example="1">%1$d</xliff:g> selected</item>

        <item quantity="other"><xliff:g id="count" example="3">%1$d</xliff:g> selected</item>

    </plurals>

    <!-- Text used as the content description of the cancel button when files are selected. -->

    <string name="clear_selection">Clear selection</string>



    <!-- Label text showing user how many items are being dragged. Can be one or more elements. -->

    <plurals name="elements_dragged">

src/com/android/documentsui/SelectionBarController.kt

+1 −1
Original line number Diff line number Diff line
@@ -86,7 +86,7 @@ class SelectionBarController( 
                )

        selectionBar.title = title

        selectionBar.setNavigationIcon(getRes(R.drawable.ic_cancel))

        selectionBar.setNavigationContentDescription(android.R.string.cancel)

        selectionBar.setNavigationContentDescription(R.string.clear_selection)

        selectionBar.setOnMenuItemClickListener { menuItemClicker?.accept(it) == true }

        selectionBar.setNavigationOnClickListener { closeSelectionBar() }

        updateSelectionMenu()