Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a61b1f5 authored by Tomasz Mikolajewski's avatar Tomasz Mikolajewski
Browse files

Hide the share button in archives. 

This is not supported, so the button should be hidden.

Test: Unit tests. Also tested manually.
Bug: 35046647
Change-Id: I86249488fa0f828149cfcac4435b1e917c2c3dc9
parent e92e4313

src/com/android/documentsui/files/MenuManager.java

+2 −1
Original line number Diff line number Diff line
@@ -213,7 +213,8 @@ public final class MenuManager extends com.android.documentsui.MenuManager { 
    @Override

    protected void updateShare(MenuItem share, SelectionDetails selectionDetails) {

        share.setVisible(!selectionDetails.containsDirectories()

                && !selectionDetails.containsPartialFiles());

                && !selectionDetails.containsPartialFiles()

                && !selectionDetails.canExtract());

    }



    @Override

tests/unit/com/android/documentsui/files/MenuManagerTest.java

+2 −1
Original line number Diff line number Diff line
@@ -177,13 +177,14 @@ public final class MenuManagerTest { 
    }



    @Test

    public void testActionMenu_canExtract_hidesCopyToAndCompressTo() {

    public void testActionMenu_canExtract_hidesCopyToAndCompressToAndShare() {

        selectionDetails.canExtract = true;

        mgr.updateActionMenu(testMenu, selectionDetails);



        extractTo.assertEnabled();

        copyTo.assertDisabled();

        compressTo.assertDisabled();

        share.assertInvisible();

    }



    @Test