Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c83a6ae authored by Sergey Nikolaienkov's avatar Sergey Nikolaienkov
Browse files

Set actionMenuTextColor in ActionBarThemeCommon 

Introduce ActionBarThemeCommon which sets android:actionMenuTextColor to
the textColorPrimary and is exteneded by all varians of ActionBarTheme.

Bug: 278312486
Bug: 270525971
Test: build and install DocumentsUIGoogle
Test: atest DocumentsUIGoogleTests
Change-Id: I2ab9fdb1f61d3b855e7d71c6471d517f7e043f22
parent 41aa3efa

res/values-night-v31/styles.xml

+3 −3
Original line number Diff line number Diff line
@@ -16,11 +16,11 @@ 
  -->



<resources>

    <style name="ActionBarTheme" parent="@style/ThemeOverlay.AppCompat.ActionBar">

        <item name="colorControlNormal">?android:textColorSecondary</item>

    <!--

    <style name="ActionBarTheme" parent="@style/ActionBarThemeCommon">

        <item name="android:actionMenuTextColor">@*android:color/accent_device_default_dark</item>

        <item name="android:textAllCaps">false</item>

    </style>

    -->



    <style name="TabTextAppearance" parent="@android:style/TextAppearance.Material.Medium">

        <item name="android:textSize">14sp</item>

res/values-v31/styles.xml

+3 −3
Original line number Diff line number Diff line
@@ -22,13 +22,13 @@ 
    <item name="android:textSize">12sp</item>

  </style>



  <style name="ActionBarTheme" parent="@style/ThemeOverlay.AppCompat.ActionBar">

    <item name="colorControlNormal">?android:textColorSecondary</item>

  <!--

  <style name="ActionBarTheme" parent="@style/ActionBarThemeCommon">

    <item name="android:actionMenuTextColor">

      @*android:color/accent_device_default_light

    </item>

    <item name="android:textAllCaps">false</item>

  </style>

  -->



  <style name="MaterialButton" parent="@style/Widget.MaterialComponents.Button.UnelevatedButton">

    <item name="android:textAppearance">@style/MaterialButtonTextAppearance

res/values/styles.xml

+11 −1
Original line number Diff line number Diff line
@@ -15,10 +15,20 @@ 
-->



<resources xmlns:android="http://schemas.android.com/apk/res/android">

    <style name="ActionBarTheme" parent="@style/ThemeOverlay.AppCompat.ActionBar">

    <style name="ActionBarThemeCommon" parent="@style/ThemeOverlay.AppCompat.ActionBar">

        <item name="colorControlNormal">?android:textColorSecondary</item>

        <!-- Modern platform themes set actionMenuTextColor to textColorPrimary. For example,

             see Theme.Material in frameworks/base/core/res/res/values/themes_material.xml.

             However, if the platform theme does not set actionMenuTextColor we are going to

             crash, so let's set it here. Additionally, most of our ActionBarTheme themes

             override this -->

        <item name="android:actionMenuTextColor">?android:textColorPrimary</item>

        <item name="android:textAllCaps">false</item>

    </style>



    <!-- This gets overridden for specific platform versions and/or configs -->

    <style name="ActionBarTheme" parent="@style/ActionBarThemeCommon"/>



    <style name="ActionModeStyle" parent="Widget.AppCompat.ActionMode">

        <!-- attr "height" was used by support lib should not in overlay scope -->

        <item name="height">@dimen/action_bar_size</item>