Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c3508f9 authored by Alex Kershaw's avatar Alex Kershaw
Browse files

Fix DocsUI cross-profile error screens in landscape 

Previously, a fixed height was being used. This worked well on Pixel in
portrait but not on other device types with smaller screens or in
landscape. This CL changes to use either 100 dp or padding on
phones/tablets in portrait, and 0 dp of padding on phones on landscape.
See screenshots in CL comments.

Also adds 48dp of padding to each side of the error message screens as
requested by UX.

Fixes: 152611582
Fixes: 152591331
Test: manual
Change-Id: Ie3ba186191ed1c4d15945a02ce545617ce8de3da
parent 9d57eb5a

res/layout/item_doc_inflated_message_cross_profile.xml

+5 −4
Original line number Diff line number Diff line
@@ -18,11 +18,12 @@ 
<LinearLayout

    xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_width="match_parent"

    android:layout_height="424dp"

    android:layout_height="wrap_content"

    android:orientation="vertical"

    android:gravity="center"

    android:paddingStart="24dp"

    android:paddingEnd="24dp">

    android:gravity="center_horizontal"

    android:paddingTop="@dimen/item_doc_inflated_message_padding_top"

    android:paddingStart="72dp"

    android:paddingEnd="72dp">



    <ImageView

        android:id="@+id/artwork"

res/values-h600dp/dimens.xml

0 → 100644
+19 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!--

  ~ Copyright (C) 2020 The Android Open Source Project

  ~

  ~ Licensed under the Apache License, Version 2.0 (the "License");

  ~ you may not use this file except in compliance with the License.

  ~ You may obtain a copy of the License at

  ~

  ~      http://www.apache.org/licenses/LICENSE-2.0

  ~

  ~ Unless required by applicable law or agreed to in writing, software

  ~ distributed under the License is distributed on an "AS IS" BASIS,

  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

  ~ See the License for the specific language governing permissions and

  ~ limitations under the License.

  -->

<resources>

    <dimen name="item_doc_inflated_message_padding_top">100dp</dimen>

</resources>

res/values/dimens.xml

+2 −0
Original line number Diff line number Diff line
@@ -121,4 +121,6 @@ 
    <dimen name="action_bar_space_margin">@dimen/action_bar_space_height</dimen>



    <dimen name="refresh_icon_range">64dp</dimen>



    <dimen name="item_doc_inflated_message_padding_top">0dp</dimen>

</resources>