Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d0daff3 authored by Ben Kwa's avatar Ben Kwa
Browse files

Fix a crash during file deletion. 

Fix an off-by-one error when checking deletion candidates, that was
causing item positions to be incorrectly bumped following a successful
deletion.

BUG=23823860

Change-Id: Id261ad49271fb0c1a5ff1cba88fea1451412d7f3
parent f86fbcd5

src/com/android/documentsui/DirectoryFragment.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -1824,7 +1824,7 @@ public class DirectoryFragment extends Fragment { 
            // position by 1.

            // position by 1.

            final int originalPos = position;

            final int originalPos = position;

            final int size = mMarkedForDeletion.size();

            final int size = mMarkedForDeletion.size();

            for (int i = 0; i <= size; ++i) {

            for (int i = 0; i < size; ++i) {

                // It'd be more concise, but less efficient, to iterate over positions while calling

                // It'd be more concise, but less efficient, to iterate over positions while calling

                // mMarkedForDeletion.get.  Instead, iterate over deleted entries.

                // mMarkedForDeletion.get.  Instead, iterate over deleted entries.

                if (mMarkedForDeletion.keyAt(i) <= position && mMarkedForDeletion.valueAt(i)) {

                if (mMarkedForDeletion.keyAt(i) <= position && mMarkedForDeletion.valueAt(i)) {