Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9d4b060 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Finishing touches for accessibility in the new call log and the new voicemail fragment"

parents aa3e6078 abd2b2f3

java/com/android/dialer/calllog/ui/res/layout/new_call_log_duo_disclosure_card.xml

+4 −3
Original line number Original line Diff line number Diff line
@@ -18,8 +18,8 @@ 
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_width="match_parent"

    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:layout_height="wrap_content"

    android:orientation="vertical"

    android:background="@color/background_dialer_light"

    android:background="@color/background_dialer_light">

    android:orientation="vertical">





  <LinearLayout

  <LinearLayout

      android:layout_width="match_parent"

      android:layout_width="match_parent"
@@ -35,7 +35,8 @@ 
        android:id="@+id/new_call_log_duo_disclosure_card_logo"

        android:id="@+id/new_call_log_duo_disclosure_card_logo"

        android:layout_width="40dp"

        android:layout_width="40dp"

        android:layout_height="40dp"

        android:layout_height="40dp"

        android:layout_marginEnd="16dp"/>

        android:layout_marginEnd="16dp"

        android:importantForAccessibility="no"/>





    <LinearLayout

    <LinearLayout

        android:layout_width="match_parent"

        android:layout_width="match_parent"

java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml

+9 −4
Original line number Original line Diff line number Diff line
@@ -75,6 +75,7 @@ 
          android:layout_width="wrap_content"

          android:layout_width="wrap_content"

          android:layout_height="18dp"

          android:layout_height="18dp"

          android:layout_gravity="center_vertical"

          android:layout_gravity="center_vertical"

          android:importantForAccessibility="no"

          android:src="@drawable/quantum_ic_hd_vd_theme_24"/>

          android:src="@drawable/quantum_ic_hd_vd_theme_24"/>





      <ImageView

      <ImageView
@@ -82,6 +83,7 @@ 
          android:layout_width="wrap_content"

          android:layout_width="wrap_content"

          android:layout_height="18dp"

          android:layout_height="18dp"

          android:layout_gravity="center_vertical"

          android:layout_gravity="center_vertical"

          android:importantForAccessibility="no"

          android:src="@drawable/quantum_ic_signal_wifi_4_bar_vd_theme_24"/>

          android:src="@drawable/quantum_ic_signal_wifi_4_bar_vd_theme_24"/>





      <ImageView

      <ImageView
@@ -89,6 +91,7 @@ 
          android:layout_width="wrap_content"

          android:layout_width="wrap_content"

          android:layout_height="18dp"

          android:layout_height="18dp"

          android:layout_gravity="center_vertical"

          android:layout_gravity="center_vertical"

          android:importantForAccessibility="no"

          android:src="@drawable/quantum_ic_language_vd_theme_24"/>

          android:src="@drawable/quantum_ic_language_vd_theme_24"/>





      <TextView

      <TextView
@@ -105,13 +108,15 @@ 
    <LinearLayout

    <LinearLayout

        android:layout_width="wrap_content"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_height="wrap_content"

        android:orientation="horizontal">

        android:orientation="horizontal"

        tools:ignore="UseCompoundDrawables">





      <ImageView

      <ImageView

          android:id="@+id/call_type_icon"

          android:id="@+id/call_type_icon"

          android:layout_width="wrap_content"

          android:layout_width="wrap_content"

          android:layout_height="18dp"

          android:layout_height="18dp"

          android:layout_gravity="center_vertical"/>

          android:layout_gravity="center_vertical"

          android:importantForAccessibility="no"/>





      <TextView

      <TextView

          android:id="@+id/secondary_text"

          android:id="@+id/secondary_text"
@@ -142,8 +147,8 @@ 
      android:layout_alignParentEnd="true"

      android:layout_alignParentEnd="true"

      android:layout_centerVertical="true"

      android:layout_centerVertical="true"

      android:background="?android:attr/selectableItemBackgroundBorderless"

      android:background="?android:attr/selectableItemBackgroundBorderless"

      android:contentDescription="@string/a11y_new_call_log_expand_menu_for_entry"

      android:scaleType="center"

      android:scaleType="center"

      android:src="@drawable/quantum_ic_more_vert_vd_theme_24"

      android:src="@drawable/quantum_ic_more_vert_vd_theme_24"

      android:tint="@color/dialer_secondary_text_color"

      android:tint="@color/dialer_secondary_text_color"/>

      android:contentDescription="@string/a11y_new_call_log_expand_menu_for_entry"/>

</RelativeLayout>
 
</RelativeLayout>

java/com/android/dialer/voicemail/listui/error/res/layout/voicemail_error_message_fragment.xml

+1 −3
Original line number Original line Diff line number Diff line
@@ -15,7 +15,6 @@ 
-->

-->

<android.support.v7.widget.CardView

<android.support.v7.widget.CardView

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:tools="http://schemas.android.com/tools"

    android:id="@+id/error_card"

    android:id="@+id/error_card"

    style="@style/CallLogCardStyle"

    style="@style/CallLogCardStyle"

    android:gravity="center_vertical"

    android:gravity="center_vertical"
@@ -43,8 +42,7 @@ 
          android:layout_height="@dimen/voicemail_promo_card_icon_size"

          android:layout_height="@dimen/voicemail_promo_card_icon_size"

          android:layout_gravity="top"

          android:layout_gravity="top"

          android:importantForAccessibility="no"

          android:importantForAccessibility="no"

          android:src="@drawable/ic_voicemail_error_24px"

          android:src="@drawable/ic_voicemail_error_24px"/>

          tools:ignore="ContentDescription"/>





      <LinearLayout

      <LinearLayout

          android:layout_width="match_parent"

          android:layout_width="match_parent"

java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_entry.xml

+1 −2
Original line number Original line Diff line number Diff line
@@ -61,8 +61,7 @@ 
          android:importantForAccessibility="no"

          android:importantForAccessibility="no"

          android:src="@drawable/quantum_ic_voicemail_vd_theme_24"

          android:src="@drawable/quantum_ic_voicemail_vd_theme_24"

          android:tint="@color/dialtacts_theme_color"

          android:tint="@color/dialtacts_theme_color"

          android:tintMode="multiply"

          android:tintMode="multiply"/>

          tools:ignore="ContentDescription"/>





      <TextView

      <TextView

          android:id="@+id/secondary_text"

          android:id="@+id/secondary_text"

java/com/android/dialer/voicemail/listui/res/layout/new_voicemail_entry_alert.xml

+1 −3
Original line number Original line Diff line number Diff line
@@ -18,7 +18,6 @@ 
<!-- TODO(uabdullah): Use a relative layout instead of nested linear layouts.-->

<!-- TODO(uabdullah): Use a relative layout instead of nested linear layouts.-->

<LinearLayout

<LinearLayout

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:tools="http://schemas.android.com/tools"

    android:id="@+id/voicemail_alert_content"

    android:id="@+id/voicemail_alert_content"

    android:layout_width="match_parent"

    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:layout_height="wrap_content"
@@ -40,8 +39,7 @@ 
        android:layout_height="@dimen/voicemail_promo_card_icon_size"

        android:layout_height="@dimen/voicemail_promo_card_icon_size"

        android:layout_gravity="top"

        android:layout_gravity="top"

        android:importantForAccessibility="no"

        android:importantForAccessibility="no"

        android:src="@drawable/ic_voicemail_error_24px"

        android:src="@drawable/ic_voicemail_error_24px"/>

        tools:ignore="ContentDescription"/>





    <LinearLayout

    <LinearLayout

        android:layout_width="match_parent"

        android:layout_width="match_parent"