Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a35059ab authored by Christine Chen's avatar Christine Chen
Browse files

Filters out legacy unknown numbers. 

- Adds "-1", "-2", "-3" as unknown number placeholders for legacy
  reasons.
- Disable calling feature for these numbers.
- Show caller info as "Unknown" for these numbers.

Bug: 10966248
Change-Id: Ibb7904685decbc602db33a56c7709279728e503d
parent 02bd6dfd

src/com/android/dialer/calllog/PhoneNumberHelper.java

+3 −0
Original line number Diff line number Diff line
@@ -56,6 +56,9 @@ public class PhoneNumberHelper { 
        if (new PhoneNumberUtilsWrapper().isVoicemailNumber(number)) {

            return mResources.getString(R.string.voicemail);

        }

        if (PhoneNumberUtilsWrapper.isLegacyUnknownNumbers(number)) {

            return mResources.getString(R.string.unknown);

        }

        if (TextUtils.isEmpty(formattedNumber)) {

            return number;

        } else {

src/com/android/dialer/calllog/PhoneNumberUtilsWrapper.java

+14 −1
Original line number Diff line number Diff line
@@ -20,15 +20,21 @@ import android.provider.CallLog; 
import android.telephony.PhoneNumberUtils;

import android.text.TextUtils;



import com.google.android.collect.Sets;



import java.util.Set;



/**

 *

 */

public class PhoneNumberUtilsWrapper {



    private static final Set<String> LEGACY_UNKNOWN_NUMBERS = Sets.newHashSet("-1", "-2", "-3");



    /** Returns true if it is possible to place a call to the given number. */

    public static boolean canPlaceCallsTo(CharSequence number, int presentation) {

        return presentation == CallLog.Calls.PRESENTATION_ALLOWED

            && !TextUtils.isEmpty(number);

            && !TextUtils.isEmpty(number) && !isLegacyUnknownNumbers(number);

    }



    /**
@@ -71,6 +77,13 @@ public class PhoneNumberUtilsWrapper { 
        if (new PhoneNumberUtilsWrapper().isVoicemailNumber(number)) {

            return false;

        }

        if (isLegacyUnknownNumbers(number.toString())) {

            return false;

        }

        return true;

    }



    public static boolean isLegacyUnknownNumbers(CharSequence number) {

        return LEGACY_UNKNOWN_NUMBERS.contains(number.toString());

    }

}