Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9172c905 authored by Brandon Maxwell's avatar Brandon Maxwell
Browse files

Enabling Dialer to play ringtones 

+ The code to make the Dialer play was disabled behind flags, this
change flips the flags so the Dialer is responsible for playing the
ringtone.
+ The in-code flag will be removed later after a QA pass of the
feature.
- Removed TODO to respect Do Not Disturb, see b/26936902

Bug=18702990

Change-Id: I773c1c614beb61a6763daccd2903d9d341cf4dc0
parent 32b16298

AndroidManifest.xml

+1 −1
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ 
                 android:encryptionAware="true" >

            <meta-data android:name="android.telecom.IN_CALL_SERVICE_UI" android:value="true" />

            <meta-data android:name="android.telecom.IN_CALL_SERVICE_RINGING"

                android:value="false"/>

                android:value="true"/>

            <intent-filter>

                <action android:name="android.telecom.InCallService"/>

            </intent-filter>

InCallUI/src/com/android/incallui/ringtone/DialerRingtoneManager.java

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ public class DialerRingtoneManager { 
     * Flag used to determine if the Dialer is responsible for playing ringtones for incoming calls.

     * Once we're ready to enable Dialer Ringing, these flags should be removed.

     */

    private static final boolean IS_DIALER_RINGING_ENABLED = false;

    private static final boolean IS_DIALER_RINGING_ENABLED = true;

    private Boolean mIsDialerRingingEnabledForTesting;



    private final InCallTonePlayer mInCallTonePlayer;

InCallUI/src/com/android/incallui/ringtone/InCallTonePlayer.java

+0 −1
Original line number Diff line number Diff line
@@ -118,7 +118,6 @@ public class InCallTonePlayer { 
    }



    private void playOnBackgroundThread(ToneGeneratorInfo info) {

        // TODO (maxwelb): b/26936902 respect Do Not Disturb setting

        ToneGenerator toneGenerator = null;

        try {

            Log.v(this, "Starting tone " + info);