Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81e373e4 authored by wangqi's avatar wangqi Committed by Copybara-Service
Browse files

Add impression logging for RTT call 

Bug: 78243122
Test: CallListTest
PiperOrigin-RevId: 194111299
Change-Id: I8cb3a0266b6796321e83a2a703630a745879be97
parent ea3b162a

java/com/android/dialer/logging/dialer_impression.proto

+11 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ message DialerImpression { 
  // Event enums to be used for Impression Logging in Dialer.

  // It's perfectly acceptable for this enum to be large

  // Values should be from 1000 to 100000.

  // Next Tag: 1382

  // Next Tag: 1387

  enum Type {

    UNKNOWN_AOSP_EVENT_TYPE = 1000;
@@ -754,5 +754,15 @@ message DialerImpression { 
    // Failure happened while enabling spam blocking through after call

    // notification promo.

    SPAM_BLOCKING_MODIFY_FAILURE_THROUGH_AFTER_CALL_NOTIFICATION_PROMO = 1381;



    // RTT call impressions

    OUTGOING_RTT_CALL = 1382;

    INCOMING_RTT_CALL = 1383;

    // The call turns into RTT call mid call.

    RTT_MID_CALL_ENABLED = 1384;

    // Mid call RTT request accepted.

    RTT_MID_CALL_ACCEPTED = 1385;

    // Mid call RTT request rejected.

    RTT_MID_CALL_REJECTED = 1386;

  }

}

java/com/android/incallui/call/CallList.java

+14 −0
Original line number Diff line number Diff line
@@ -213,8 +213,22 @@ public class CallList implements DialerCallDelegate { 


    if (call.getState() == DialerCall.State.INCOMING

        || call.getState() == DialerCall.State.CALL_WAITING) {

      if (call.isActiveRttCall()) {

        Logger.get(context)

            .logCallImpression(

                DialerImpression.Type.INCOMING_RTT_CALL,

                call.getUniqueCallId(),

                call.getTimeAddedMs());

      }

      onIncoming(call);

    } else {

      if (call.isActiveRttCall()) {

        Logger.get(context)

            .logCallImpression(

                DialerImpression.Type.OUTGOING_RTT_CALL,

                call.getUniqueCallId(),

                call.getTimeAddedMs());

      }

      onUpdateCall(call);

      notifyGenericListeners();

    }

java/com/android/incallui/call/DialerCall.java

+14 −0
Original line number Diff line number Diff line
@@ -312,6 +312,13 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa 
        @Override

        public void onRttStatusChanged(Call call, boolean enabled, RttCall rttCall) {

          LogUtil.v("TelecomCallCallback.onRttStatusChanged", "enabled=%b", enabled);

          if (enabled) {

            Logger.get(context)

                .logCallImpression(

                    DialerImpression.Type.RTT_MID_CALL_ENABLED,

                    getUniqueCallId(),

                    getTimeAddedMs());

          }

          update();

        }
@@ -1064,6 +1071,13 @@ public class DialerCall implements VideoTechListener, StateChangedListener, Capa 


  @TargetApi(28)

  public void respondToRttRequest(boolean accept, int rttRequestId) {

    Logger.get(context)

        .logCallImpression(

            accept

                ? DialerImpression.Type.RTT_MID_CALL_ACCEPTED

                : DialerImpression.Type.RTT_MID_CALL_REJECTED,

            getUniqueCallId(),

            getTimeAddedMs());

    getTelecomCall().respondToRttRequest(rttRequestId, accept);

  }