Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 668b99f9 authored by uabdullah's avatar uabdullah Committed by Copybara-Service
Browse files

Add assert check for INVALID NUMBERS in NUI Voicemail 

We do not expect any invalid numbers for the voicemail tab. We crash the app if an invalid number is detected in the NUI VM tab, so that we can handle invalid numbers for voicemail accordingly.

Bug: 72863479
Test: N/A
PiperOrigin-RevId: 184333020
Change-Id: Ifd769da08c7cba3aab555b56eef799de47810fb3
parent 056c1911

java/com/android/dialer/voicemail/listui/VoicemailCursorLoader.java

+9 −0
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ import android.support.v4.content.CursorLoader; 
import com.android.dialer.DialerPhoneNumber;

import com.android.dialer.NumberAttributes;

import com.android.dialer.calllog.database.contract.AnnotatedCallLogContract.AnnotatedCallLog;

import com.android.dialer.common.Assert;

import com.android.dialer.common.LogUtil;

import com.android.dialer.voicemail.model.VoicemailEntry;

import com.google.protobuf.InvalidProtocolBufferException;
@@ -84,6 +86,13 @@ final class VoicemailCursorLoader extends CursorLoader { 
      throw new IllegalStateException("Couldn't parse NumberAttributes bytes");

    }



    // Voicemail numbers should always be valid so the CP2 information should never be incomplete,

    // and there should be no need to query PhoneLookup at render time.

    Assert.checkArgument(

        !numberAttributes.getIsCp2InfoIncomplete(),

        "CP2 info incomplete for number: %s",

        LogUtil.sanitizePii(number.getNormalizedNumber()));



    return VoicemailEntry.builder()

        .setId(cursor.getInt(ID))

        .setTimestamp(cursor.getLong(TIMESTAMP))