Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c1ab52e authored by Andrew Lee's avatar Andrew Lee
Browse files

Fix shortcut action text length issues. 

+ Lower shortcut char limits. There's probably 40 characters of
space on a N6, but less on smaller devices.
+ Shorten "Add to existing contact" to "add to contact".

Bug: 21550993
Change-Id: I136b01cd90ae36e07b7f567294e68316a57856a0
parent 11412dc1

res/values/strings.xml

+5 −5
Original line number Diff line number Diff line
@@ -495,17 +495,17 @@ 
    </string>



    <!-- Shortcut item used to add a number directly to a new contact from search.

         [CHAR LIMIT=40] -->

         [CHAR LIMIT=25] -->

    <string name="search_shortcut_create_new_contact">Create new contact</string>



    <!-- Shortcut item used to add a number to an existing contact directly from search.

         [CHAR LIMIT=40] -->

    <string name="search_shortcut_add_to_existing_contact">Add to existing contact</string>

         [CHAR LIMIT=25] -->

    <string name="search_shortcut_add_to_contact">Add to contact</string>



    <!-- Shortcut item used to send a text message directly from search. [CHAR LIMIT=40] -->

    <!-- Shortcut item used to send a text message directly from search. [CHAR LIMIT=25] -->

    <string name="search_shortcut_send_sms_message">Send SMS</string>



    <!-- Shortcut item used to make a video call directly from search. -->

    <!-- Shortcut item used to make a video call directly from search. [CHAR LIMIT=25] -->

    <string name="search_shortcut_make_video_call">Make video call</string>



    <!-- Title for the call log list item that brings users to the full call history when clicked -->

src/com/android/dialer/list/DialerPhoneNumberListAdapter.java

+1 −1
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ public class DialerPhoneNumberListAdapter extends PhoneNumberListAdapter { 
                drawableId = R.drawable.ic_search_add_contact;

                break;

            case SHORTCUT_ADD_TO_EXISTING_CONTACT:

                text = resources.getString(R.string.search_shortcut_add_to_existing_contact);

                text = resources.getString(R.string.search_shortcut_add_to_contact);

                drawableId = R.drawable.ic_person_24dp;

                break;

            case SHORTCUT_SEND_SMS_MESSAGE: