Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4deaebc5 authored by uabdullah's avatar uabdullah Committed by Copybara-Service
Browse files

Move legacy voicemail/error to nui voicemail/listui/error 

All packages relating to NUI voicemail should be under third_party/java_src/android_app/dialer/java/com/android/dialer/voicemail/listui. Since there is a chance that during NUI development the legacy third_party/java_src/android_app/dialer/java/com/android/dialer/app/voicemail/error might undergo changes, it makes sense to move this package to the nui, so that no changes in the legacy code are missed for nui. This refactoring would also allow us to ensure that the strings do not need to be translated and that most of the code can be re-used for nui by hooking up the fragment and adapter to voicemail/listui/error.

Bug: 71700117
Test: Unit tests
PiperOrigin-RevId: 182868896
Change-Id: I23329654df5ce2bf612101708ed001ca308ae1ac
parent c979f257

java/com/android/dialer/app/calllog/CallLogReceiver.java

+2 −2
Original line number Diff line number Diff line
@@ -21,10 +21,10 @@ import android.content.Context; 
import android.content.Intent;

import android.database.Cursor;

import android.provider.VoicemailContract;

import com.android.dialer.app.voicemail.error.VoicemailStatusCorruptionHandler;

import com.android.dialer.app.voicemail.error.VoicemailStatusCorruptionHandler.Source;

import com.android.dialer.common.LogUtil;

import com.android.dialer.database.CallLogQueryHandler;

import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler;

import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler.Source;



/**

 * Receiver for call log events.

java/com/android/dialer/app/calllog/VisualVoicemailCallLogFragment.java

+3 −3
Original line number Diff line number Diff line
@@ -33,15 +33,15 @@ import com.android.dialer.app.list.ListsFragment; 
import com.android.dialer.app.voicemail.VoicemailAudioManager;

import com.android.dialer.app.voicemail.VoicemailErrorManager;

import com.android.dialer.app.voicemail.VoicemailPlaybackPresenter;

import com.android.dialer.app.voicemail.error.VoicemailErrorMessageCreator;

import com.android.dialer.app.voicemail.error.VoicemailStatus;

import com.android.dialer.app.voicemail.error.VoicemailStatusWorker;

import com.android.dialer.common.LogUtil;

import com.android.dialer.common.concurrent.DialerExecutor;

import com.android.dialer.common.concurrent.DialerExecutorComponent;

import com.android.dialer.logging.DialerImpression;

import com.android.dialer.logging.Logger;

import com.android.dialer.util.PermissionsUtil;

import com.android.dialer.voicemail.listui.error.VoicemailErrorMessageCreator;

import com.android.dialer.voicemail.listui.error.VoicemailStatus;

import com.android.dialer.voicemail.listui.error.VoicemailStatusWorker;

import java.util.List;



public class VisualVoicemailCallLogFragment extends CallLogFragment {

java/com/android/dialer/app/list/ListsFragment.java

+2 −2
Original line number Diff line number Diff line
@@ -36,8 +36,6 @@ import com.android.dialer.app.R; 
import com.android.dialer.app.calllog.CallLogFragment;

import com.android.dialer.app.calllog.CallLogNotificationsService;

import com.android.dialer.app.calllog.VisualVoicemailCallLogFragment;

import com.android.dialer.app.voicemail.error.VoicemailStatusCorruptionHandler;

import com.android.dialer.app.voicemail.error.VoicemailStatusCorruptionHandler.Source;

import com.android.dialer.common.LogUtil;

import com.android.dialer.database.CallLogQueryHandler;

import com.android.dialer.database.CallLogQueryHandler.Listener;
@@ -48,6 +46,8 @@ import com.android.dialer.logging.UiAction; 
import com.android.dialer.performancereport.PerformanceReport;

import com.android.dialer.speeddial.SpeedDialFragment;

import com.android.dialer.util.PermissionsUtil;

import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler;

import com.android.dialer.voicemail.listui.error.VoicemailStatusCorruptionHandler.Source;

import com.android.dialer.voicemailstatus.VisualVoicemailEnabledChecker;

import com.android.dialer.voicemailstatus.VoicemailStatusHelper;

import java.util.ArrayList;

java/com/android/dialer/app/voicemail/VoicemailErrorManager.java

+4 −4
Original line number Diff line number Diff line
@@ -28,13 +28,13 @@ import android.telephony.TelephonyManager; 
import android.util.ArrayMap;

import com.android.dialer.app.calllog.CallLogAlertManager;

import com.android.dialer.app.calllog.CallLogModalAlertManager;

import com.android.dialer.app.voicemail.error.VoicemailErrorAlert;

import com.android.dialer.app.voicemail.error.VoicemailErrorMessageCreator;

import com.android.dialer.app.voicemail.error.VoicemailStatus;

import com.android.dialer.app.voicemail.error.VoicemailStatusReader;

import com.android.dialer.common.Assert;

import com.android.dialer.common.LogUtil;

import com.android.dialer.database.CallLogQueryHandler;

import com.android.dialer.voicemail.listui.error.VoicemailErrorAlert;

import com.android.dialer.voicemail.listui.error.VoicemailErrorMessageCreator;

import com.android.dialer.voicemail.listui.error.VoicemailStatus;

import com.android.dialer.voicemail.listui.error.VoicemailStatusReader;

import com.android.voicemail.VoicemailComponent;

import java.util.ArrayList;

import java.util.List;