Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 443d758d authored by Yorke Lee's avatar Yorke Lee
Browse files

Don't close cursor manually in PhoneFavoritesTileAdapter 

This seems to mess up the ability to receive further notifications when
the data underlying the cursor changes. The framework will automatically
close the cursor when it is no longer needed.

Bug: 10117074
Change-Id: I8721c955aebf8fd1826c1eebfb158376d204f0fa
parent 1a94e742

src/com/android/dialer/list/PhoneFavoritesTileAdapter.java

+21 −25
Original line number Diff line number Diff line
@@ -213,7 +213,6 @@ public class PhoneFavoritesTileAdapter extends BaseAdapter { 
     */

    private void saveCursorToCache(Cursor cursor) {

        mContactEntries.clear();

        try {

        cursor.moveToPosition(-1);

        while (cursor.moveToNext()) {

            final long id = cursor.getLong(mIdIndex);
@@ -236,9 +235,6 @@ public class PhoneFavoritesTileAdapter extends BaseAdapter { 
            contact.phoneNumber = cursor.getString(mPhoneNumberIndex);

            mContactEntries.add(contact);

        }

        } finally {

            cursor.close();

        }

    }



    /**