Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32cabd8d authored by weijiaxu's avatar weijiaxu Committed by Copybara-Service
Browse files

set connection state after adding NonSimulatorConnectionListener and set... 

set connection state after adding NonSimulatorConnectionListener and set connection to active at the end.

This is necessary to make sure that NonSimulatorConnectionListener gets event callback when Connection.setDialing() or Connection.setActive() is called.

Test: On a local device.
PiperOrigin-RevId: 187266120
Change-Id: I6ee5d5113285e7a27a4e8497a95b28844ac6b397
parent 37434b49

java/com/android/dialer/simulator/impl/SimulatorConnectionService.java

+3 −1
Original line number Diff line number Diff line
@@ -84,7 +84,6 @@ public class SimulatorConnectionService extends ConnectionService { 
      return null;

    }

    SimulatorConnection connection = new SimulatorConnection(this, request);

    connection.setDialing();

    if (SimulatorSimCallManager.isSimulatorConnectionRequest(request)) {

      simulatorConnectionsBank.add(connection);

      connection.setAddress(
@@ -92,6 +91,7 @@ public class SimulatorConnectionService extends ConnectionService { 
          request

              .getExtras()

              .getInt(Simulator.PRESENTATION_CHOICE, TelecomManager.PRESENTATION_ALLOWED));

      connection.setDialing();

      ThreadUtil.postOnUiThread(

          () ->

              SimulatorComponent.get(instance)
@@ -107,6 +107,8 @@ public class SimulatorConnectionService extends ConnectionService { 
      connection.putExtras(extras);

      simulatorConnectionsBank.add(connection);

      connection.addListener(new NonSimulatorConnectionListener());

      connection.setDialing();

      ThreadUtil.postOnUiThread(connection::setActive);

    }

    return connection;

  }