Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25bb49e1 authored by linyuh's avatar linyuh Committed by Copybara-Service
Browse files

Replace TextView with BidiTextView in the new call log where a phone number can be shown. 

Bug: 72162627
Test: Existing tests
PiperOrigin-RevId: 199190694
Change-Id: I19f2ae7e8af452062672c67eb1be1bc6cc49b855
parent 444a3aea

java/com/android/dialer/calllog/ui/res/layout/new_call_log_entry.xml

+7 −7
Original line number Diff line number Diff line
@@ -53,18 +53,18 @@ 
      <!--

          Important note:



          The following TextView is the only widget that defines a weight in the containing

          The following BidiTextView is the only widget that defines a weight in the containing

          LinearLayout, of which the purpose is to avoid pushing the widgets after it out of the

          boundary when the text is too long.



          Generally it is more efficient to assign a width/height of 0dp so that the TextView does

          not have to measure its own size since it will absorb all the remaining space anyway.

          Generally it is more efficient to assign a width/height of 0dp so that the BidiTextView

          does not have to measure its own size since it will absorb all the remaining space anyway.



          However, as the TextView is part of an entry in the call log's RecyclerView, we must set

          layout_width to "wrap_content" so that the TextView can adjust its size when recycled for

          text of different lengths.

          However, as the BidiTextView is part of an entry in the call log's RecyclerView, we must

          set layout_width to "wrap_content" so that the TextView can adjust its size when recycled

          for text of different lengths.

      -->

      <TextView

      <com.android.dialer.widget.BidiTextView

          android:id="@+id/primary_text"

          style="@style/Dialer.TextAppearance.Primary.Ellipsize"

          android:layout_width="wrap_content"

java/com/android/dialer/historyitemactions/res/layout/contact_layout.xml

+2 −2
Original line number Diff line number Diff line
@@ -39,13 +39,13 @@ 
      android:gravity="center_vertical"

      android:orientation="vertical">



    <TextView

    <com.android.dialer.widget.BidiTextView

        android:id="@+id/primary_text"

        style="@style/Dialer.TextAppearance.Primary.Ellipsize"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"/>



    <TextView

    <com.android.dialer.widget.BidiTextView

        android:id="@+id/secondary_text"

        style="@style/Dialer.TextAppearance.Secondary.Ellipsize"

        android:layout_width="wrap_content"