Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb82c8cc authored by Itzhak Katzenelson's avatar Itzhak Katzenelson
Browse files

Fix jerkiness in alarm list 

Bug: 7411618
Moved scrolling runnable to be activated only in "onClick"
calls and not on all calls to expandAlarm.

Change-Id: Iace92a79e39ebfc038a258c5b4155daa77227031
parent 73f70be8

src/com/android/deskclock/AlarmClock.java

+2 −1
Original line number Original line Diff line number Diff line
@@ -651,6 +651,7 @@ public class AlarmClock extends Activity implements LoaderManager.LoaderCallback 
                    }

                    }

                    AlarmUtils.showTimeEditDialog(AlarmClock.this.getFragmentManager(), alarm);

                    AlarmUtils.showTimeEditDialog(AlarmClock.this.getFragmentManager(), alarm);

                    expandAlarm(itemHolder);

                    expandAlarm(itemHolder);

                    itemHolder.alarmItem.post(mScrollRunnable);

                }

                }

            });

            });

            itemHolder.clock.setOnLongClickListener(mLongClickListener);

            itemHolder.clock.setOnLongClickListener(mLongClickListener);
@@ -666,6 +667,7 @@ public class AlarmClock extends Activity implements LoaderManager.LoaderCallback 
                        return;

                        return;

                    }

                    }

                    expandAlarm(itemHolder);

                    expandAlarm(itemHolder);

                    itemHolder.alarmItem.post(mScrollRunnable);

                }

                }

            });

            });

            itemHolder.infoArea.setOnLongClickListener(mLongClickListener);

            itemHolder.infoArea.setOnLongClickListener(mLongClickListener);
@@ -994,7 +996,6 @@ public class AlarmClock extends Activity implements LoaderManager.LoaderCallback 
            bindExpandArea(itemHolder, itemHolder.alarm);

            bindExpandArea(itemHolder, itemHolder.alarm);

            // Scroll the view to make sure it is fully viewed

            // Scroll the view to make sure it is fully viewed

            mScrollAlarmId = itemHolder.alarm.id;

            mScrollAlarmId = itemHolder.alarm.id;

            itemHolder.alarmItem.post(mScrollRunnable);

        }

        }





        private boolean isAlarmExpanded(Alarm alarm) {

        private boolean isAlarmExpanded(Alarm alarm) {