Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 969a1bd2 authored by Pawit Pornkitprasan's avatar Pawit Pornkitprasan
Browse files

Clock: fix layout for 320dp devices 

800x480px dpi devices have less screen space than the xhdpi devices
Google designed the layout for and the layout needs adjustment.

The number in the timer (left-most tab) is cut off on older devices.
Adjust the weight (per Jie W.'s suggestion) so that it can be
displayed properly.

It is impossible to account for all languages with very long translation
for "H" "M" and "S", and that can only be fixed by de-localization or
re-localization.

This should not have any effect on devices with larger screens.

Change-Id: If61b676f220a6f1c39105fe3948946100a5f64b2
parent de67b856

res/layout/time_setup_view.xml

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ 
        <com.android.deskclock.timer.TimerView

            android:id="@+id/timer_time_text"

            android:layout_width="0dip"

            android:layout_weight="2"

            android:layout_weight="@integer/timer_weight"

            android:layout_height="wrap_content"

            android:paddingTop="@dimen/medium_font_padding"

            android:paddingBottom="@dimen/medium_font_padding"

res/values-w360dp/dimens.xml

0 → 100644
+25 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!--

/*

** Copyright 2011, The Android Open Source Project

** Copyright 2012, The CyanogenMod Project

**

** Licensed under the Apache License, Version 2.0 (the "License");

** you may not use this file except in compliance with the License.

** You may obtain a copy of the License at

**

**     http://www.apache.org/licenses/LICENSE-2.0

**

** Unless required by applicable law or agreed to in writing, software

** distributed under the License is distributed on an "AS IS" BASIS,

** WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

** See the License for the specific language governing permissions and

** limitations under the License.

*/

-->



<!-- These resources are around just to allow their values to be customized

     for different hardware and product builds. -->

<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">

    <integer name="timer_weight">2</integer>

</resources>

res/values/dimens.xml

+1 −0
Original line number Diff line number Diff line
@@ -152,4 +152,5 @@ 
    <dimen name="def_digital_widget_height">70dip</dimen>

    <dimen name="digital_widget_list_margin_top">12dip</dimen>



    <integer name="timer_weight">4</integer>

</resources>