Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50d41a71 authored by Christine Franks's avatar Christine Franks
Browse files

Remove drop shadow when switching tabs 

Bug: 32017748
Test: swipe between tabs and observe no drop shadow. Vertically scroll
alarms and clock tabs and observe a drop shadow appear when not scrolled
to top.

Change-Id: Ia4e295bc507defcf1fbcb52a73c97931fa289b24
parent 588d99be

src/com/android/deskclock/DeskClock.java

+0 −6
Original line number Diff line number Diff line
@@ -672,12 +672,6 @@ public class DeskClock extends BaseActivity 
                mFabState = FabState.HIDE_ARMED;

            }



            if (state == SCROLL_STATE_DRAGGING && mPriorState != SCROLL_STATE_DRAGGING) {

                mDropShadowController.setHorizontallyScrolling(false);

            } else if (state != SCROLL_STATE_DRAGGING && mPriorState == SCROLL_STATE_DRAGGING) {

                mDropShadowController.setHorizontallyScrolling(true);

            }



            // Update the last known state.

            mPriorState = state;

        }

src/com/android/deskclock/DropShadowController.java

+0 −11
Original line number Diff line number Diff line
@@ -140,17 +140,6 @@ public final class DropShadowController { 
        }

    }



    /**

     * Update the drop shadow when dragging to switch tabs.

     *

     * @param scrollHasEnded {@code true} indicates the drop shadow should be hidden;

     *      {@code false} indicates the drop shadow should be displayed

     */

    public void setHorizontallyScrolling(boolean scrollHasEnded) {

        // Show if scroll started or if it's ended, but we've scrolled down the page.

        updateDropShadow(!scrollHasEnded || !mUiDataModel.isSelectedTabScrolledToTop());

    }



    /**

     * Update the drop shadow as the scrollable entity is scrolled.

     */