From 0b3ab6b39a5ed8ea8c79b99a8b505b3cb614ae88 Mon Sep 17 00:00:00 2001
From: SayantanRC <sayantan.rc@e.email>
Date: Wed, 22 Nov 2023 20:56:17 +0530
Subject: [PATCH 1/2] account selector theme and text color fixes

---
 res/layout/account_selector_list_item_condensed.xml | 2 +-
 res/layout/dialog_title.xml                         | 2 +-
 res/values/styles.xml                               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/res/layout/account_selector_list_item_condensed.xml b/res/layout/account_selector_list_item_condensed.xml
index ae91726033..84174a1464 100644
--- a/res/layout/account_selector_list_item_condensed.xml
+++ b/res/layout/account_selector_list_item_condensed.xml
@@ -38,7 +38,7 @@
             android:layout_marginRight="8dip"
             android:layout_marginEnd="8dip"
             android:textSize="16sp"
-            android:textColor="@color/contacts_text_color"
+            android:textColor="?android:attr/textColorPrimary"
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:singleLine="true"
             android:ellipsize="end"/>
diff --git a/res/layout/dialog_title.xml b/res/layout/dialog_title.xml
index 45f5f73676..63fcf0b232 100644
--- a/res/layout/dialog_title.xml
+++ b/res/layout/dialog_title.xml
@@ -22,7 +22,7 @@
     android:paddingStart="24dp"
     android:paddingEnd="24dp"
     android:textSize="20sp"
-    android:textColor="@color/contacts_text_color"
+    android:textColor="?android:attr/textColorPrimary"
     android:textAlignment="viewStart"
     android:fontFamily="sans-serif-medium"
     android:ellipsize="end"
diff --git a/res/values/styles.xml b/res/values/styles.xml
index 9af3e1f9b8..bbb825c992 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -298,7 +298,7 @@
         <item name="android:windowCloseOnTouchOutside">true</item>
     </style>
 
-    <style name="ContactEditorAccountsChangedActivityTheme" parent="@android:style/Theme.Material.Light.Dialog.NoActionBar.MinWidth">
+    <style name="ContactEditorAccountsChangedActivityTheme" parent="Theme.AppCompat.DayNight.Dialog.MinWidth">
         <item name="android:windowCloseOnTouchOutside">true</item>
         <item name="android:textColorPrimary">@color/primary_text_color</item>
         <item name="android:textColorSecondary">@color/secondary_text_color</item>
-- 
GitLab


From 32a40d2d45a9367f0c5d2cbe78e605d3e759a8cd Mon Sep 17 00:00:00 2001
From: Sayantan Roychowdhury <sayantan.rc@e.email>
Date: Mon, 27 Nov 2023 21:32:19 +0530
Subject: [PATCH 2/2] remove text2

---
 res/layout/account_selector_list_item_condensed.xml    | 10 ----------
 .../android/contacts/util/AccountSelectionUtil.java    |  6 +-----
 src/com/android/contacts/util/AccountsListAdapter.java |  6 +-----
 3 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/res/layout/account_selector_list_item_condensed.xml b/res/layout/account_selector_list_item_condensed.xml
index 84174a1464..a7de3c0237 100644
--- a/res/layout/account_selector_list_item_condensed.xml
+++ b/res/layout/account_selector_list_item_condensed.xml
@@ -42,15 +42,5 @@
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:singleLine="true"
             android:ellipsize="end"/>
-
-        <TextView android:id="@android:id/text2"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_marginEnd="24dp"
-            android:textSize="14sp"
-            android:textAppearance="?android:attr/textAppearanceSmall"
-            android:textColor="?android:attr/textColorSecondary"
-            android:singleLine="true"
-            android:ellipsize="end"/>
     </LinearLayout>
 </LinearLayout>
diff --git a/src/com/android/contacts/util/AccountSelectionUtil.java b/src/com/android/contacts/util/AccountSelectionUtil.java
index 2b226d0a10..4cf2a88c85 100644
--- a/src/com/android/contacts/util/AccountSelectionUtil.java
+++ b/src/com/android/contacts/util/AccountSelectionUtil.java
@@ -116,7 +116,6 @@ public class AccountSelectionUtil {
                 }
 
                 final TextView text1 = (TextView) convertView.findViewById(android.R.id.text1);
-                final TextView text2 = (TextView) convertView.findViewById(android.R.id.text2);
                 final ImageView icon = (ImageView) convertView.findViewById(android.R.id.icon);
 
                 final AccountWithDataSet account = this.getItem(position);
@@ -124,10 +123,7 @@ public class AccountSelectionUtil {
                         account.type, account.dataSet);
                 final Context context = getContext();
 
-                text1.setText(accountType.getDisplayLabel(context));
-                text2.setText(account.name);
-                text2.setVisibility(context.getPackageName().equals(account.type) ?
-                        View.GONE : View.VISIBLE);
+                text1.setText(account.name);
                 icon.setImageDrawable(accountType.getDisplayIcon(getContext()));
 
                 return convertView;
diff --git a/src/com/android/contacts/util/AccountsListAdapter.java b/src/com/android/contacts/util/AccountsListAdapter.java
index cc80b7985f..63f9935cdd 100644
--- a/src/com/android/contacts/util/AccountsListAdapter.java
+++ b/src/com/android/contacts/util/AccountsListAdapter.java
@@ -90,13 +90,9 @@ public final class AccountsListAdapter extends BaseAdapter {
                         R.layout.account_selector_list_item_condensed, parent, false);
 
         final TextView text1 = (TextView) resultView.findViewById(android.R.id.text1);
-        final TextView text2 = (TextView) resultView.findViewById(android.R.id.text2);
         final ImageView icon = (ImageView) resultView.findViewById(android.R.id.icon);
 
-        text1.setText(mAccounts.get(position).getTypeLabel());
-        text2.setText(mAccounts.get(position).getNameLabel());
-        text2.setVisibility(mAccounts.get(position).getNameLabel().equals(
-                mAccounts.get(position).getTypeLabel()) ? View.GONE : View.VISIBLE);
+        text1.setText(mAccounts.get(position).getNameLabel());
 
         icon.setImageDrawable(mAccounts.get(position).getIcon());
 
-- 
GitLab