Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eea34c1e authored by Frank Sposaro's avatar Frank Sposaro
Browse files

Bug fixes for ContactTileRow 

-Fixed push states on frequent contacts
-ContactTileRow is no longer clickable
-Keyboard navigation is enabled for favorites screens
**depends on https://android-git.corp.google.com/g/#/c/128328/1**
-Minor padding width fix

Bug: 5163130
Bug: 5071772
Bug: 5171573
Change-Id: I570d6fd1670f4911472328b0a3412d6153b606fd
parent 9d58f279

res/layout/contact_tile_frequent.xml

+3 −1
Original line number Diff line number Diff line
@@ -17,7 +17,8 @@ 
    xmlns:android="http://schemas.android.com/apk/res/android"

    class="com.android.contacts.list.ContactTileView"

    android:focusable="true"

    android:background="@null"

    android:background="?android:attr/selectableItemBackground"

    android:nextFocusRight="@+id/contact_tile_quick"

    android:paddingRight="16dip"

    android:paddingLeft="16dip" >
@@ -30,6 +31,7 @@ 
            android:layout_width="64dip"

            android:layout_height="64dip"

            android:scaleType="centerCrop"

            android:focusable="true"

            android:layout_alignParentRight="true" />



        <LinearLayout

res/layout/contact_tile_frequent_phone.xml

+6 −2
Original line number Diff line number Diff line
@@ -14,10 +14,12 @@ 
     limitations under the License.

-->

<view

    android:id="@+id/contact_tile_frequent_phone"

    xmlns:android="http://schemas.android.com/apk/res/android"

    class="com.android.contacts.list.ContactTileView"

    android:focusable="true"

    android:background="@null"

    android:background="?android:attr/selectableItemBackground"

    android:nextFocusLeft="@+id/contact_tile_quick"

    android:paddingRight="16dip"

    android:paddingLeft="16dip" >
@@ -26,10 +28,12 @@ 
        android:layout_height="match_parent" >



        <QuickContactBadge

            android:id="@+id/contact_tile_quick"

            android:id="@id/contact_tile_quick"

            android:nextFocusRight="@id/contact_tile_frequent_phone"

            android:layout_width="64dip"

            android:layout_height="64dip"

            android:scaleType="centerCrop"

            android:focusable="true"

            android:layout_alignParentLeft="true" />



        <TextView

res/layout/contact_tile_starred.xml

+1 −0
Original line number Diff line number Diff line
@@ -70,6 +70,7 @@ 
            android:id="@+id/contact_tile_push_state"

            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:focusable="true"

            android:background="?android:attr/selectableItemBackground" />



    </RelativeLayout>

res/layout/contact_tile_starred_quick_contact.xml

+1 −0
Original line number Diff line number Diff line
@@ -69,6 +69,7 @@ 
            android:id="@+id/contact_tile_quick"

            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:focusable="true"

            android:background="@null" />



    </RelativeLayout>

res/layout/contact_tile_starred_secondary_target.xml

+3 −1
Original line number Diff line number Diff line
@@ -51,10 +51,12 @@ 
            android:id="@+id/contact_tile_push_state"

            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:focusable="true"

            android:nextFocusRight="@+id/contact_tile_secondary_button"

            android:background="?android:attr/selectableItemBackground" />



        <ImageButton

            android:id="@+id/contact_tile_secondary_button"

            android:id="@id/contact_tile_secondary_button"

            android:src="@drawable/ic_contacts_holo_dark"

            android:background="?android:attr/selectableItemBackground"

            android:layout_height="@dimen/contact_tile_shadowbox_height"