Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b504605f authored by yaolu's avatar yaolu
Browse files

Fix the "Add Contacts" button too small in empty label view 

Change the "Add Contacts" button style so that clickable area is
larger and meets a11y requirement.
Remove the padding between the text and button.

Screenshots on N5 with clickable area shown:
https://drive.google.com/open?id=0BxaQ3Ze9jz_cWkwwT1p5a2ZrRWc
https://drive.google.com/open?id=0BxaQ3Ze9jz_cb2FFMVhnUXdKT00

Bug 30442846

Change-Id: I34a6bdea0ba52ed5f358633d40d15d94b6e4785f
parent 39e0e13b

res/layout/empty_group_view.xml

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 
        android:layout_height="wrap_content"

        android:layout_gravity="center_horizontal"

        android:paddingTop="@dimen/empty_group_view_text_padding_top"

        android:paddingBottom="@dimen/empty_group_view_text_padding_bottom"

        android:text="@string/emptyGroup"

        style="@style/EmptyStateTextStyle"/>

res/values-land/dimens.xml

+1 −2
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ 
    <!-- Height for the image for empty group view-->

    <dimen name="empty_group_view_image_height">150dp</dimen>



    <!-- Top and Bottom padding for the text for empty group view-->

    <!-- Top padding for the text for empty group view-->

    <dimen name="empty_group_view_text_padding_top">14dp</dimen>

    <dimen name="empty_group_view_text_padding_bottom">10dp</dimen>

</resources>

res/values-land/integers.xml

+2 −2
Original line number Diff line number Diff line
@@ -18,5 +18,5 @@ 
    <integer name="quickcontact_title_lines">2</integer>



    <!-- Top margin ratio for the image for empty group view -->

    <integer name="empty_group_view_image_margin">12</integer>

    <integer name="empty_group_view_image_margin_divisor">12</integer>

</resources>

res/values-sw600dp-land/dimens.xml

+1 −2
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ 
    <!-- Height for the image for empty group view-->

    <dimen name="empty_group_view_image_height">180dp</dimen>



    <!-- Top and Bottom padding for the text for empty group view-->

    <!-- Top padding for the text for empty group view -->

    <dimen name="empty_group_view_text_padding_top">32dp</dimen>

    <dimen name="empty_group_view_text_padding_bottom">16dp</dimen>

</resources>

res/values-sw600dp-land/integers.xml

+2 −2
Original line number Diff line number Diff line
@@ -22,5 +22,5 @@ 
    <integer name="contact_list_card_layout_weight">6</integer>



    <!-- Top margin ratio for the image for empty group view -->

    <integer name="empty_group_view_image_margin">8</integer>

    <integer name="empty_group_view_image_margin_divisor">8</integer>

</resources>