Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a831c0b5 authored by Hugo Hudson's avatar Hugo Hudson
Browse files

Use CopyOnWriteArrayList for listeners. 

- We were previously using a list of Listener objects, specifically a
  LinkedList, and synchronizing on the list to maintain thread-safety.
- This cl replaces the LinkedList with a CopyOnWriteArrayList, which is
  specifically made for this kind of situation.

A bit more background:
- During the notify period, we had the classic anti-pattern of holding
  the lock whilst calling foreign methods (the listener
  onServiceCompleted methods).
- It's very evil to call foreign methods with a lock held, since this
  can easily lead to deadlock.  In this case, if any of our Listener
  implementations or any future Listener implementations yet to be
  written were to block until some other thread registers or unregisters
  a listener, we will have deadlock.
- CopyOnWriteArrayList needs no explicit synchronization - see its
  javadoc.

Change-Id: If2251e740a9f266e28956ac5acc52054debb3461
parent 8a854eb9

src/com/android/contacts/ContactSaveService.java

+10 −15
Original line number Diff line number Diff line
@@ -53,8 +53,8 @@ import android.widget.Toast; 


import java.util.ArrayList;

import java.util.HashSet;

import java.util.LinkedList;

import java.util.List;

import java.util.concurrent.CopyOnWriteArrayList;



/**

 * A service responsible for saving changes to the content provider.
@@ -133,7 +133,8 @@ public class ContactSaveService extends IntentService { 
        public void onServiceCompleted(Intent callbackIntent);

    }



    private static final LinkedList<Listener> sListeners = new LinkedList<Listener>();

    private static final CopyOnWriteArrayList<Listener> sListeners =

            new CopyOnWriteArrayList<Listener>();



    private Handler mMainHandler;
@@ -148,16 +149,12 @@ public class ContactSaveService extends IntentService { 
            throw new ClassCastException("Only activities can be registered to"

                    + " receive callback from " + ContactSaveService.class.getName());

        }

        synchronized (sListeners) {

            sListeners.addFirst(listener);

        }

        sListeners.add(0, listener);

    }



    public static void unregisterListener(Listener listener) {

        synchronized (sListeners) {

        sListeners.remove(listener);

    }

    }



    @Override

    public Object getSystemService(String name) {
@@ -975,7 +972,6 @@ public class ContactSaveService extends IntentService { 
        // TODO: this assumes that if there are multiple instances of the same

        // activity registered, the last one registered is the one waiting for

        // the callback. Validity of this assumption needs to be verified.

        synchronized (sListeners) {

        for (Listener listener : sListeners) {

            if (callbackIntent.getComponent().equals(

                    ((Activity) listener).getIntent().getComponent())) {
@@ -985,4 +981,3 @@ public class ContactSaveService extends IntentService { 
        }

    }

}
 
}