Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93ea7280 authored by Walter Jang's avatar Walter Jang
Browse files

Revert "Revert "Add an activity to ask for optional permissions""

This reverts commit 8bb93a831595c082809554e09545ed1dcd437fa6.

Change-Id: I9feddfa024f229b3a42ae091cab12b09ac4e7f90
parent fecad2c2
Loading
Loading
Loading
Loading
+74 −0
Original line number Diff line number Diff line
/*
 * Copyright (C) 2016 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.contacts.common.activity;

import android.Manifest.permission;
import android.app.Activity;
import android.content.Intent;

/**
 * Requests permissions that are not absolutely required by the calling Activity;
 * if permissions are denied, the calling Activity is still restarted.
 *
 * Activities that have a set of permissions that must be granted in order for the Activity to
 * function propertly should call
 * {@link RequestPermissionsActivity#startPermissionActivity(Activity, String[], Class)}
 * before calling {@link RequestDesiredPermissionsActivity#startPermissionActivity(Activity)}.
 */
public class RequestDesiredPermissionsActivity extends RequestPermissionsActivityBase {

    private static final String[] DESIRED_PERMISSIONS = new String[] {
            permission.ACCESS_FINE_LOCATION,
            permission.READ_CALENDAR,
            permission.READ_SMS,
    };

    @Override
    protected String[] getRequiredPermissions() {
        return DESIRED_PERMISSIONS;
    }

    @Override
    protected String[] getDesiredPermissions() {
        return DESIRED_PERMISSIONS;
    }

    /**
     * If any desired permissions the Contacts app needs are missing, open an Activity
     * to prompt the user for these permissions.
     *
     * This is designed to be called inside {@link android.app.Activity#onCreate}
     */
    public static boolean startPermissionActivity(Activity activity) {
        if (activity.getIntent().getExtras().getBoolean(STARTED_PERMISSIONS_ACTIVITY, false)) {
            return false;
        }
        return startPermissionActivity(activity, DESIRED_PERMISSIONS,
                RequestDesiredPermissionsActivity.class);
    }

    @Override
    public void onRequestPermissionsResult(
            int requestCode, String permissions[], int[] grantResults) {
        mPreviousActivityIntent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
        startActivity(mPreviousActivityIntent);
        overridePendingTransition(0, 0);

        finish();
        overridePendingTransition(0, 0);
    }
}
 No newline at end of file
+20 −0
Original line number Diff line number Diff line
@@ -16,8 +16,12 @@

package com.android.contacts.common.activity;

import com.android.contacts.common.R;

import android.Manifest.permission;
import android.app.Activity;
import android.content.Intent;
import android.widget.Toast;

/**
 * Activity that requests permissions needed for activities exported from Contacts.
@@ -48,8 +52,24 @@ public class RequestPermissionsActivity extends RequestPermissionsActivityBase {
                permission.READ_SMS, // SMS group
        };
    }

    public static boolean startPermissionActivity(Activity activity) {
        return startPermissionActivity(activity, REQUIRED_PERMISSIONS,
                RequestPermissionsActivity.class);
    }

    @Override
    public void onRequestPermissionsResult(
            int requestCode, String permissions[], int[] grantResults) {
        if (permissions != null && permissions.length > 0
                && isAllGranted(permissions, grantResults)) {
            mPreviousActivityIntent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
            startActivity(mPreviousActivityIntent);
            finish();
            overridePendingTransition(0, 0);
        } else {
            Toast.makeText(this, R.string.missing_required_permission, Toast.LENGTH_SHORT).show();
            finish();
        }
    }
}
+9 −19
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ import android.os.Bundle;
import android.os.Trace;
import android.support.v4.app.ActivityCompat;
import android.support.v4.content.ContextCompat;
import android.widget.Toast;

import java.util.ArrayList;
import java.util.Arrays;
@@ -41,7 +40,12 @@ import java.util.Arrays;
 */
public abstract class RequestPermissionsActivityBase extends Activity
        implements ActivityCompat.OnRequestPermissionsResultCallback {

    public static final String PREVIOUS_ACTIVITY_INTENT = "previous_intent";

    /** Whether the permissions activity was already started. */
    protected static final String STARTED_PERMISSIONS_ACTIVITY = "started_permissions_activity";

    private static final int PERMISSIONS_REQUEST_ALL_PERMISSIONS = 1;

    /**
@@ -56,7 +60,7 @@ public abstract class RequestPermissionsActivityBase extends Activity
     */
    protected abstract String[] getDesiredPermissions();

    private Intent mPreviousActivityIntent;
    protected Intent mPreviousActivityIntent;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
@@ -79,8 +83,9 @@ public abstract class RequestPermissionsActivityBase extends Activity
     */
    protected static boolean startPermissionActivity(Activity activity,
            String[] requiredPermissions, Class<?> newActivityClass) {
        if (!RequestPermissionsActivity.hasPermissions(activity, requiredPermissions)) {
        if (!hasPermissions(activity, requiredPermissions)) {
            final Intent intent = new Intent(activity,  newActivityClass);
            activity.getIntent().putExtra(STARTED_PERMISSIONS_ACTIVITY, true);
            intent.putExtra(PREVIOUS_ACTIVITY_INTENT, activity.getIntent());
            activity.startActivity(intent);
            activity.finish();
@@ -96,22 +101,7 @@ public abstract class RequestPermissionsActivityBase extends Activity
        return false;
    }

    @Override
    public void onRequestPermissionsResult(int requestCode, String permissions[],
            int[] grantResults) {
        if (permissions != null && permissions.length > 0
                && isAllGranted(permissions, grantResults)) {
            mPreviousActivityIntent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
            startActivity(mPreviousActivityIntent);
            finish();
            overridePendingTransition(0, 0);
        } else {
            Toast.makeText(this, R.string.missing_required_permission, Toast.LENGTH_SHORT).show();
            finish();
        }
    }

    private boolean isAllGranted(String permissions[], int[] grantResult) {
    protected boolean isAllGranted(String permissions[], int[] grantResult) {
        for (int i = 0; i < permissions.length; i++) {
            if (grantResult[i] != PackageManager.PERMISSION_GRANTED
                    && isPermissionRequired(permissions[i])) {