Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9203788d authored by Brian Attwell's avatar Brian Attwell
Browse files

Map MenuItems to ViewPager tabs correctly in RTL 

Also improved the handling of the mContactsUnavailableFragment in RTL.
The tabs still don't work perfectly in RTL for mContactsUnavailableFragment,
but this isn't a regression (and proved very tricky to solve without
changing the design). I'll file a bug for the remaining work after
checking this in.

Bug: 18011426
Change-Id: I695018464625f3f8329a33882d2d728f61c3b110
parent 711c3440

src/com/android/contacts/activities/PeopleActivity.java

+2 −2
Original line number Diff line number Diff line
@@ -572,7 +572,7 @@ public class PeopleActivity extends ContactsActivity implements 


    private void showEmptyStateForTab(int tab) {

        if (mContactsUnavailableFragment != null) {

            switch (tab) {

            switch (getTabPositionForTextDirection(tab)) {

                case TabState.FAVORITES:

                    mContactsUnavailableFragment.setMessageText(

                            R.string.listTotalAllContactsZeroStarred, -1);
@@ -1022,7 +1022,7 @@ public class PeopleActivity extends ContactsActivity implements 
            clearFrequentsMenu.setVisible(false);

            helpMenu.setVisible(false);

        } else {

            switch (mActionBarAdapter.getCurrentTab()) {

            switch (getTabPositionForTextDirection(mActionBarAdapter.getCurrentTab())) {

                case TabState.FAVORITES:

                    contactsFilterMenu.setVisible(false);

                    clearFrequentsMenu.setVisible(hasFrequents());