Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cd9af38 authored by Wenyi Wang's avatar Wenyi Wang
Browse files

Avoid changing list view padding to zero 

When we set top padding, we also set other paddings to zero,
which caused the layout of list view on tablets to be wrong.

Bug 30180750
Bug 29190106

Change-Id: Ief1519e20df403d83b0682081b0160144890383b
parent 92942632

src/com/android/contacts/list/MultiSelectContactsListFragment.java

+9 −3
Original line number Diff line number Diff line
@@ -351,7 +351,7 @@ public abstract class MultiSelectContactsListFragment<T extends MultiSelectEntry 
    private void bindListHeaderCommon(View listView, View accountFilterContainer) {

        // Show header and remove top padding of the list

        accountFilterContainer.setVisibility(View.VISIBLE);

        listView.setPadding(0, 0, 0, 0);

        setListViewPaddingTop(listView, /* paddingTop */ 0);

    }



    /**
@@ -360,8 +360,14 @@ public abstract class MultiSelectContactsListFragment<T extends MultiSelectEntry 
    protected void hideHeaderAndAddPadding(Context context, View listView,

            View accountFilterContainer) {

        accountFilterContainer.setVisibility(View.GONE);

        listView.setPadding(0, context.getResources().getDimensionPixelSize(

                R.dimen.contact_browser_list_item_padding_top_or_bottom), 0, 0);

        setListViewPaddingTop(listView,

                /* paddingTop */ context.getResources().getDimensionPixelSize(

                        R.dimen.contact_browser_list_item_padding_top_or_bottom));

    }



    private void setListViewPaddingTop(View listView, int paddingTop) {

        listView.setPadding(listView.getPaddingLeft(), paddingTop, listView.getPaddingRight(),

                listView.getPaddingBottom());

    }



}