Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69f67d00 authored by Ben Gilad's avatar Ben Gilad
Browse files

Add missing contentDescription tags. 

bug: 11067808
Change-Id: Ib4032f3ca93635e02ab328e9dc7be7a5b4596e6e
parent 96d423b2

res/layout/quickcontact_photo_container.xml

+7 −5
Original line number Diff line number Diff line
@@ -25,7 +25,8 @@ 
            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:scaleType="centerCrop"

            android:clickable="true" />

            android:clickable="true"

            android:contentDescription="@string/description_contact_photo" />

        <View

            android:layout_width="match_parent"

            android:layout_height="1dip"
@@ -44,7 +45,6 @@ 
        <ImageView

            android:id="@+id/contact_details_image"

            android:src="@drawable/ic_contacts_holo_dark"

            android:contentDescription="@null"

            android:layout_height="wrap_content"

            android:layout_width="wrap_content"

            android:layout_marginRight="16dip"
@@ -53,7 +53,8 @@ 
            android:layout_alignBottom="@id/photo_text_bar"

            android:layout_alignRight="@id/photo_text_bar"

            android:layout_alignEnd="@id/photo_text_bar"

            android:clickable="true"/>

            android:clickable="true"

            android:contentDescription="@string/viewContactDesription" />

        <ImageView

            android:id="@+id/quickcontact_star_button"

            android:src="@drawable/ic_favorite_off_lt"
@@ -65,7 +66,8 @@ 
            android:layout_alignBottom="@id/photo_text_bar"

            android:layout_toLeftOf="@id/contact_details_image"

            android:layout_toStartOf="@id/contact_details_image"

            android:clickable="true"/>

            android:clickable="true"

            android:contentDescription="@string/menu_addStar" />

        <TextView

            android:id="@+id/name"

            android:layout_width="match_parent"

res/values/strings.xml

+2 −2
Original line number Diff line number Diff line
@@ -451,10 +451,10 @@ 
    <!-- The button to add an organization field to a contact in the Raw Contact Editor [CHAR LIMIT=15] -->

    <string name="group_edit_field_hint_text">Group name</string>



    <!-- Attbution of a contact status update, when the time of update is unknown -->

    <!-- Attribution of a contact status update, when the time of update is unknown -->

    <string name="contact_status_update_attribution">via <xliff:g id="source" example="Google Talk">%1$s</xliff:g></string>



    <!-- Attbution of a contact status update, when the time of update is known -->

    <!-- Attribution of a contact status update, when the time of update is known -->

    <string name="contact_status_update_attribution_with_date"><xliff:g id="date" example="3 hours ago">%1$s</xliff:g> via <xliff:g id="source" example="Google Talk">%2$s</xliff:g></string>



    <!-- String describing the Star/Favorite checkbox

src/com/android/contacts/quickcontact/QuickContactActivity.java

+4 −0
Original line number Diff line number Diff line
@@ -375,8 +375,12 @@ public class QuickContactActivity extends Activity { 
        final boolean isStarred = data.getStarred();

        if (isStarred) {

            mStarImage.setImageResource(R.drawable.ic_favorite_on_lt);

            mStarImage.setContentDescription(

                getResources().getString(R.string.menu_removeStar));

        } else {

            mStarImage.setImageResource(R.drawable.ic_favorite_off_lt);

            mStarImage.setContentDescription(

                getResources().getString(R.string.menu_addStar));

        }

        final Uri lookupUri = data.getLookupUri();