Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 450b88f0 authored by Neel Parekh's avatar Neel Parekh
Browse files

Show header to user when fields were hidden since they were read-only. 

Bug: 2121692
parent 16d6b342

res/layout/item_contact_editor.xml

+13 −5
Original line number Diff line number Diff line
@@ -22,14 +22,21 @@ 
    android:fillViewport="true">



    <TextView

        android:id="@+id/text_summary"

        android:id="@+id/edit_read_only"

        android:layout_width="fill_parent"

        android:layout_height="0dip" />

        android:layout_height="wrap_content"

        android:gravity="center|center_vertical"

        android:textAppearance="?android:attr/textAppearanceMedium"

        android:paddingTop="5dip"

        android:paddingBottom="5dip"

        android:text="@string/edit_read_only"/>



    <FrameLayout

        android:id="@+id/stub_photo"

        android:layout_width="100dip"

        android:layout_height="96dip"

        android:layout_below="@id/edit_read_only"

        android:layout_alignWithParentIfMissing="true"

        android:paddingLeft="12dip"

        android:paddingTop="10dip">
@@ -43,10 +50,11 @@ 
        android:id="@+id/edit_name"

        android:layout_width="fill_parent"

        android:layout_height="wrap_content"

        android:layout_below="@id/text_summary"

        android:layout_below="@id/edit_read_only"

        android:layout_toRightOf="@id/stub_photo"

        android:layout_marginTop="6dip"

        android:layout_marginBottom="4dip"

        android:layout_alignWithParentIfMissing="true"

        layout="@layout/item_generic_editor" />



    <LinearLayout

res/values/strings.xml

+3 −0
Original line number Diff line number Diff line
@@ -911,6 +911,9 @@ 
    <!-- Single-character overlay for other phone numbers when creating desktop shortcuts -->

    <string name="type_short_other">O</string>



    <!-- In edit dialog, shown if the contact is marked as being read-only -->

    <string name="edit_read_only">This contact is read-only</string>



    <!-- Shown as the header title over a collapsible section that, by default, hides

         secondary contact detail edit fields, such as birthday. -->

    <string name="edit_secondary_collapse">Secondary details</string>

src/com/android/contacts/ui/widget/ContactEditorView.java

+6 −0
Original line number Diff line number Diff line
@@ -56,6 +56,8 @@ import android.widget.TextView; 
public class ContactEditorView extends RelativeLayout implements OnClickListener {

    private LayoutInflater mInflater;



    private TextView mReadOnly;



    private PhotoEditorView mPhoto;

    private GenericEditorView mName;
@@ -89,6 +91,8 @@ public class ContactEditorView extends RelativeLayout implements OnClickListener 


        final int photoSize = getResources().getDimensionPixelSize(R.dimen.edit_photo_size);



        mReadOnly = (TextView)findViewById(R.id.edit_read_only);



        mName = (GenericEditorView)findViewById(R.id.edit_name);

        mName.setMinimumHeight(photoSize);

        mName.setDeletable(false);
@@ -170,6 +174,8 @@ public class ContactEditorView extends RelativeLayout implements OnClickListener 
        mHasPhotoEditor = (source.getKindForMimetype(Photo.CONTENT_ITEM_TYPE) != null);

        mPhoto.setVisibility(mHasPhotoEditor ? View.VISIBLE : View.GONE);



        mReadOnly.setVisibility(source.readOnly ? View.VISIBLE : View.GONE);



        // Create editor sections for each possible data kind

        for (DataKind kind : source.getSortedDataKinds()) {

            // Skip kind of not editable