Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24a7fe16 authored by guanxiongliu's avatar guanxiongliu
Browse files

Enhancing keyboard navigation performance 

Making all linear fields in contact editor reachable by keyboard
directional buttons navigation

Bug:12018376
Change-Id: I83b6e10c5a877235f998031060b6ee42178a02f9
parent c423ee61

res/layout/compact_contact_editor_fields.xml

+1 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 
    <LinearLayout

            style="@style/SelectableItem"

            android:id="@+id/more_fields"

            android:focusable="true"

            android:layout_width="match_parent"

            android:layout_height="wrap_content"

            android:orientation="vertical">

res/layout/compact_contact_editor_fragment.xml

+7 −7
Original line number Diff line number Diff line
@@ -32,10 +32,6 @@ 


        <include layout="@layout/compact_photo_editor_view" />



        <include layout="@layout/editor_all_rawcontacts_accounts_selector" />

        <include layout="@layout/compact_account_info" />

        <include layout="@layout/editor_account_selector" />



        <!-- Dummy view so the first input field is not initially focused. b/21644158 -->

        <View

            android:layout_width="0dp"
@@ -43,6 +39,10 @@ 
            android:focusable="true"

            android:focusableInTouchMode="true"/>



        <include layout="@layout/editor_all_rawcontacts_accounts_selector" />

        <include layout="@layout/compact_account_info" />

        <include layout="@layout/editor_account_selector" />



        <include layout="@layout/compact_contact_editor_fields" />



    </com.android.contacts.editor.CompactRawContactsEditorView>

res/layout/editor_account_selector.xml

+10 −10
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
<LinearLayout

        xmlns:android="http://schemas.android.com/apk/res/android"

        android:id="@+id/account_selector_container"

        android:focusable="true"

        android:layout_height="wrap_content"

        android:layout_width="match_parent"

        android:minHeight="@dimen/editor_min_line_item_height"
@@ -41,8 +42,7 @@ 
        android:layout_gravity="center_vertical"

        android:orientation="vertical"

        android:layout_marginStart="4dp"

        android:layout_marginEnd="48dp"

        >

        android:layout_marginEnd="48dp">



        <TextView

            android:id="@+id/account_type_selector"