Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fc98e07 authored by Josh Gargus's avatar Josh Gargus
Browse files

Improved section headers. 

Remove unnecessary padding view, and adjust the section-header heights
directly.  Now the height is what UX has wanted for a while.

Bug: 6427081
Change-Id: I83180ccd4ae7f27bcd504d93321a38523d8280c5
parent cc5b1294

res/values-sw580dp/styles.xml

+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ 
        <item name="list_item_header_text_indent">8dip</item>

        <item name="list_item_header_text_size">14sp</item>

        <item name="list_item_header_text_color">@color/people_app_theme_color</item>

        <item name="list_item_header_height">26dip</item>

        <item name="list_item_header_height">32dip</item>

        <item name="list_item_header_underline_height">1dip</item>

        <item name="list_item_header_underline_color">@color/people_app_theme_color</item>

        <item name="list_item_data_width_weight">5</item>

res/values-sw680dp/styles.xml

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ 
        <item name="list_item_prefix_highlight_color">@color/people_app_theme_color</item>

        <item name="list_item_header_text_indent">8dip</item>

        <item name="list_item_header_text_color">@color/people_app_theme_color</item>

        <item name="list_item_header_height">24dip</item>

        <item name="list_item_header_height">32dip</item>

        <item name="list_item_header_text_size">14sp</item>

        <item name="list_item_header_underline_color">@color/people_app_theme_color</item>

        <item name="list_item_header_underline_height">1dip</item>

res/values/styles.xml

+1 −1
Original line number Diff line number Diff line
@@ -152,7 +152,7 @@ 
        <item name="list_item_prefix_highlight_color">@color/people_app_theme_color</item>

        <item name="list_item_header_text_color">@color/people_app_theme_color</item>

        <item name="list_item_header_text_size">14sp</item>

        <item name="list_item_header_height">26dip</item>

        <item name="list_item_header_height">32dip</item>

        <item name="list_item_header_underline_height">1dip</item>

        <item name="list_item_header_underline_color">@color/people_app_theme_color</item>

        <item name="list_item_data_width_weight">5</item>

src/com/android/contacts/list/DefaultContactBrowseListFragment.java

+0 −10
Original line number Diff line number Diff line
@@ -56,8 +56,6 @@ public class DefaultContactBrowseListFragment extends ContactBrowseListFragment 
    private View mSearchProgress;

    private TextView mSearchProgressText;



    private View mPaddingView;



    private class FilterHeaderClickListener implements OnClickListener {

        @Override

        public void onClick(View view) {
@@ -258,8 +256,6 @@ public class DefaultContactBrowseListFragment extends ContactBrowseListFragment 
        mProfileTitle.setVisibility(show ? View.VISIBLE : View.GONE);

        mMessageContainer.setVisibility(show ? View.VISIBLE : View.GONE);

        mProfileMessage.setVisibility(show ? View.VISIBLE : View.GONE);



        mPaddingView.setVisibility(show ? View.GONE : View.VISIBLE);

    }



    /**
@@ -295,11 +291,5 @@ public class DefaultContactBrowseListFragment extends ContactBrowseListFragment 
                startActivity(intent);

            }

        });



        View paddingViewContainer =

                inflater.inflate(R.layout.contact_detail_list_padding, null, false);

        mPaddingView = paddingViewContainer.findViewById(R.id.contact_detail_list_padding);

        mPaddingView.setVisibility(View.GONE);

        getListView().addHeaderView(paddingViewContainer);

    }

}