Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09a33b40 authored by Daisuke Miyakawa's avatar Daisuke Miyakawa
Browse files

Remove illegal state exception entirely

There's no easy way to tell if the id is invalid or not, as the
id may come from outside the fragment if we're using ViewPager.

DialpadFragment on the other hand ignores unknown ids. Let's ignore
it here too.

Bug: 5067067
Change-Id: I7b4ef764beca526baf6d72d47ca5d4d0094e32e9
parent 402d5c9c
Loading
Loading
Loading
Loading
+1 −5
Original line number Diff line number Diff line
@@ -1012,12 +1012,8 @@ public class CallLogFragment extends ListFragment implements ViewPagerVisibility
                mCallLogQueryHandler.fetchVoicemailOnly();
                return true;
            }
            case R.id.menu_call_settings_call_log: {
                // Intent is already set.
                return false;
            }
            default:
                throw new IllegalArgumentException("unknown menu item: " + item.getItemId());
                return false;
        }
    }

+2 −1
Original line number Diff line number Diff line
@@ -1143,9 +1143,10 @@ public class DialpadFragment extends Fragment
            case R.id.menu_add_wait:
                updateDialString(";");
                return true;
        }
            default:
                return false;
        }
    }

    @Override
    public boolean onMenuItemClick(MenuItem item) {