Commit d3a59a04 authored Jun 29, 2015 by Dhananjay Kumar Committed by Dan Pasanen Sep 12, 2016

post_proc: fix crash in offload effect bundle during stop output

Effect bundle stop() frees mixer contol before doing module stop(),
whereas module's stop() still needs this control to send disable
command down the layer.
Crash is observed if memory associated with effect control is reused
and gets altered by the time mixer control is completed.
Move mixer control's deletion after module's stop() to fix this issue.

CRs-Fixed: 860604
Change-Id: Ia8b6d5f847b69392afbda1ba77fc740a47aba25d

parent 37bffc80

post_proc/bundle.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -311,6 +311,9 @@ int offload_effects_bundle_hal_stop_output(audio_io_handle_t output, int pcm_id)
	fx_ctxt->ops.stop(fx_ctxt, out_ctxt);		fx_ctxt->ops.stop(fx_ctxt, out_ctxt);
	}		}

			if (out_ctxt->mixer)
			mixer_close(out_ctxt->mixer);

	list_remove(&out_ctxt->outputs_list_node);		list_remove(&out_ctxt->outputs_list_node);

	#ifdef DTS_EAGLE		#ifdef DTS_EAGLE