Offload Visualizer CAPTURE_DEVICE changed on tavil (wahoo) (c76a5353) · Commits · e / os / android_hardware_qcom_audio

The offload effect capture card has always been the nb 8 before wahoo devices. This value 8 was hard-coded in the offload visualizer even though on Wahoo the correct value is 7. The proper fix would be to link with the hal to retrieve the correct value depending on the platform configuration. Nevertheless there is no time for MR1 for this proper fix. This hack will be reverted in master as soon as qcom provides the fix. Bug: 64373855 Bug: 65026253 Bug: 65263761 Test: enabled visualizer on mp3 music (play music) in test app Change-Id: I2036f694a6028c637582e55aa71ef56b4fa9d328 Signed-off-by:

Kevin Rocard <krocard@google.com>

visualizer/Android.mk

+8 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,14 @@ LOCAL_SHARED_LIBRARIES := \
		libdl \
		libtinyalsa

		# HACK to set the right record proxy effect card number.
		# It should be retrieved from the primary hal USECASE_AUDIO_RECORD_AFE_PROXY.
		ifneq ($(filter msm8998,$(TARGET_BOARD_PLATFORM)),)
		LOCAL_CFLAGS := -DCAPTURE_DEVICE=7
		else
		LOCAL_CFLAGS := -DCAPTURE_DEVICE=8
		endif

		LOCAL_HEADER_LIBRARIES := libhardware_headers

		LOCAL_MODULE_RELATIVE_PATH := soundfx

visualizer/offload_visualizer.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -181,7 +181,6 @@ int thread_status;

		#define MIXER_CARD 0
		#define SOUND_CARD 0
		#define CAPTURE_DEVICE 8

		/* Proxy port supports only MMAP read and those fixed parameters*/
		#define AUDIO_CAPTURE_CHANNEL_COUNT 2