Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38230961 authored by Satish Babu Patakokila's avatar Satish Babu Patakokila Committed by Gerrit - the friendly Code Review server
Browse files

audio-hal: gef: Remove access check for gef library 

- access function needs absolute path of the library for which
access permissions are to be checked.
- This would need two different library paths for 64-bit and 32-bit
architectures.
- To avoid this, avoid access check and rely on the dlopen error.

Change-Id: Idbcc4f5a848b528a8e90382e40017b078fbd9996
parent f8c64ee3

hal/audio_extn/gef.c

+46 −52
Original line number Diff line number Diff line
@@ -109,15 +109,12 @@ static acdb_device_type make_acdb_device_type_from_gef_cal_type 


void audio_extn_gef_init(struct audio_device *adev)

{

    int ret = 0;

    const char* error = NULL;



    ALOGV("%s: Enter with error", __func__);



    memset(&gef_hal_handle, 0, sizeof(gef_data));



    ret = access(GEF_LIBRARY, R_OK);

    if (ret == 0) {

    //: check error for dlopen

    gef_hal_handle.handle = dlopen(GEF_LIBRARY, RTLD_LAZY);

    if (gef_hal_handle.handle == NULL) {
@@ -166,12 +163,9 @@ void audio_extn_gef_init(struct audio_device *adev) 


        gef_hal_handle.gef_ptr = gef_hal_handle.init((void*)adev);

    }

    } else {

        ALOGE("%s: %s access failed", __func__, GEF_LIBRARY);

    }



ERROR_RETURN:

    ALOGV("%s: Exit with error %d", __func__, ret);

    ALOGV("%s: Exit with error ", __func__);

    return;

}