Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 206ec0c1 authored by Sachin Mohan Gadag's avatar Sachin Mohan Gadag Committed by Gerrit - the friendly Code Review server
Browse files

qahw: test: Fix variable overflow issue 

Garbage values are seen in kpi measurement
in both audio and record usecase because
of overflow of long data type variable.
To avoid overflow typecasting long data type
to uint64_t data type.

Change-Id: Icd1e6a84d295245b44de971af7b3025ce117b042
parent 653aaefa

qahw_api/test/qahw_multi_record_test.c

+1 −1
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ void *start_input(void *thread_param) 
      fread((void *) latencyBuf, 100, 1, fdLatencyNode);

      fclose(fdLatencyNode);

      sscanf(latencyBuf, " %llu,%llu", &tsec, &tusec);

      tCont = tsCont.tv_sec*1000 - tsec*1000 + tsCont.tv_nsec/1000000 - tusec/1000;

      tCont = ((uint64_t)tsCont.tv_sec)*1000 - tsec*1000 + ((uint64_t)tsCont.tv_nsec)/1000000 - tusec/1000;

      if (log_file != stdout) {

          fprintf(stdout, "\n cold latency %llums, continuous latency %llums, handle(%d)\n", tCold, tCont, params->handle);

          fprintf(stdout, " **Note: please add DSP Pipe/PP latency numbers to this, for final latency values\n");

qahw_api/test/qahw_playback_test.c

+2 −2
Original line number Diff line number Diff line
@@ -1017,8 +1017,8 @@ int measure_kpi_values(qahw_stream_handle_t* out_handle, bool is_offload) { 
    fread((void *) latency_buf, 100, 1, fd_latency_node);

    fclose(fd_latency_node);

    sscanf(latency_buf, " %llu,%llu,%*llu,%*llu,%llu,%llu", &scold, &uscold, &scont, &uscont);

    tcold = scold*1000 - ts_cold.tv_sec*1000 + uscold/1000 - ts_cold.tv_nsec/1000000;

    tcont = scont*1000 - ts_cont.tv_sec*1000 + uscont/1000 - ts_cont.tv_nsec/1000000;

    tcold = scold*1000 - ((uint64_t)ts_cold.tv_sec)*1000 + uscold/1000 - ((uint64_t)ts_cold.tv_nsec)/1000000;

    tcont = scont*1000 - ((uint64_t)ts_cont.tv_sec)*1000 + uscont/1000 - ((uint64_t)ts_cont.tv_nsec)/1000000;

    fprintf(log_file, "\n values from debug node %s\n", latency_buf);

    fprintf(log_file, " cold latency %llums, continuous latency %llums,\n", tcold, tcont);

    fprintf(log_file, " **Note: please add DSP Pipe/PP latency numbers to this, for final latency values\n");