Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcf186bd authored by Kevin Rocard's avatar Kevin Rocard
Browse files

Audio HAL VTS: Some methods are not optional 



Some mandatory methods were allowed to return NOT_SUPPORTED
although their implementations is mandatory.

Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug: 36311550
Change-Id: Ibe4b3cf73257309975ed11269a38315051fa9064
Signed-off-by: default avatarKevin Rocard <krocard@google.com>
parent 257c2f1a

audio/2.0/vts/functional/AudioPrimaryHidlHalTest.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1076,7 +1076,7 @@ static void testPrepareForReading(IStreamIn* stream, uint32_t frameSize, 
    ASSERT_OK(stream->prepareForReading(

        frameSize, framesCount,

        [&res](auto r, auto&, auto&, auto&, auto&) { res = r; }));

    EXPECT_RESULT(invalidArgsOrNotSupported, res);

    EXPECT_RESULT(Result::INVALID_ARGUMENTS, res);

}



TEST_P(InputStreamTest, PrepareForReadingWithZeroBuffer) {
@@ -1144,7 +1144,7 @@ static void testPrepareForWriting(IStreamOut* stream, uint32_t frameSize, 
    ASSERT_OK(stream->prepareForWriting(

        frameSize, framesCount,

        [&res](auto r, auto&, auto&, auto&, auto&) { res = r; }));

    EXPECT_RESULT(invalidArgsOrNotSupported, res);

    EXPECT_RESULT(Result::INVALID_ARGUMENTS, res);

}



TEST_P(OutputStreamTest, PrepareForWriteWithZeroBuffer) {