Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8ce2138 authored by David Gross's avatar David Gross
Browse files

Fix documentation. 

1. Fix documentation for Operand::numberOfConsumers.
2. Fix typos.

Bug: 69055733
Bug: 76016141
Bug: 74111771

Test: NeuralNetworksTest_static
Test: VtsHalNeuralnetworksV1_0TargetTest --hal_service_instance=android.hardware.neuralnetworks@1.0::IDevice/sample-all
Test: VtsHalNeuralnetworksV1_1TargetTest --hal_service_instance=android.hardware.neuralnetworks@1.1::IDevice/sample-all

Merged-In: Ib3d5bbfa701070597731992c3867f72d7b0280bd

Change-Id: I9572b51fa5d3fef01554a5386bd4137215e52599
(cherry picked from commit 541e2431)
parent 126e8f70

current.txt

+5 −0
Original line number Diff line number Diff line
@@ -245,3 +245,8 @@ f66f9a38541bf92001d3adcce678cd7e3da2262124befb460b1c9aea9492813b android.hardwar 
73e03573494ba96f0e711ab7f1956c5b2d54c3da690cd7ecf4d6d0f287447730 android.hardware.neuralnetworks@1.0::IPreparedModelCallback

f4945e397b5dea41bb64518dfde59be71245d8a125fd1e0acffeb57ac7b08fed android.hardware.thermal@1.1::IThermal

c8bc853546dd55584611def2a9fa1d99f657e3366c976d2f60fe6b8aa6d2cb87 android.hardware.thermal@1.1::IThermalCallback



# Future changes to HALs

5804ca86611d72e5481f022b3a0c1b334217f2e4988dad25730c42af2d1f4d1c android.hardware.neuralnetworks@1.0::IDevice

088b30a9c9ce27bc955b08a03c38c208f8f65b51133053c7656c875479801b99 android.hardware.neuralnetworks@1.0::types

neuralnetworks/1.0/IDevice.hal

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ interface IDevice { 
    /**

     * Gets the supported operations in a model.

     *

     * getSupportedSubgraph indicates which operations of a model are fully

     * getSupportedOperations indicates which operations of a model are fully

     * supported by the vendor driver. If an operation may not be supported for

     * any reason, getSupportedOperations must return false for that operation.

     *

neuralnetworks/1.0/types.hal

+5 −1
Original line number Diff line number Diff line
@@ -1079,7 +1079,11 @@ struct Operand { 
    vec<uint32_t> dimensions;



    /**

     * The number of operations that use this operand as input.

     * The number of times this operand appears as an operation input.

     *

     * (For example, if this operand appears once in one operation's

     * input list, and three times in another operation's input list,

     * then numberOfConsumers = 4.)

     */

    uint32_t numberOfConsumers;

neuralnetworks/1.0/vts/functional/Callbacks.h

+0 −4
Original line number Diff line number Diff line
@@ -38,10 +38,6 @@ using ::android::sp; 
 * "notify". This "notify" call awakens any client threads waiting on the

 * callback object.

 *

 * callback object. When the asynchronous task has finished its workload or has

 * failed to launch, it must immediately call "notify", awakening any client

 * threads waiting on the callback object.

 *

 * The CallbackBase class implements some of the base synchronization common to

 * both PrepareModelCallback and ExecutionCallback. For consistency, any HIDL

 * callback class must inherit from CallbackBase as well as the HIDL callback

neuralnetworks/1.1/IDevice.hal

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ interface IDevice extends @1.0::IDevice { 
    /**

     * Gets the supported operations in a model.

     *

     * getSupportedSubgraph indicates which operations of a model are fully

     * getSupportedOperations indicates which operations of a model are fully

     * supported by the vendor driver. If an operation may not be supported for

     * any reason, getSupportedOperations must return false for that operation.

     *