Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f54971ab authored by Michael Wright's avatar Michael Wright
Browse files

Remove PowerHint::DISABLE_TOUCH 

This isn't really a power hint and doesn't given the opportunity for the
input system to clean up any on going input streams or input fusion, so
shouldn't be part of the power HAL.

Test: run vts, play with device
Bug: 30143923
Change-Id: I7b63a2f07a7851739d90099af45773acead58548
parent 6fdbe863

power/1.0/types.hal

+0 −9
Original line number Diff line number Diff line
@@ -76,15 +76,6 @@ enum PowerHint : uint32_t { 
    * it has been launched.

    */

    LAUNCH = 0x00000008,



   /*

    * When device enters some special modes, e.g. theater mode in Android

    * Wear, there is no touch interaction expected between device and user.

    * Touch controller could be disabled in those modes to save power.

    * The data parameter is non-zero when touch could be disabled, and zero

    * when touch needs to be re-enabled.

    */

    DISABLE_TOUCH = 0x00000009

};



enum Feature : uint32_t {

power/1.0/vts/functional/power_hidl_hal_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ TEST_F(PowerHidlTest, PowerHint) { 
                PowerHint::VIDEO_ENCODE,  PowerHint::VIDEO_DECODE,

                PowerHint::LOW_POWER,     PowerHint::SUSTAINED_PERFORMANCE,

                PowerHint::VR_MODE,       PowerHint::LAUNCH,

                PowerHint::DISABLE_TOUCH, badHint};

                badHint};

  Return<void> ret;

  for (auto hint : hints) {

    ret = power->powerHint(hint, 1);

power/1.0/vts/types.vts

+0 −4
Original line number Diff line number Diff line
@@ -43,10 +43,6 @@ attribute: { 
        scalar_value: {

            uint32_t: 8

        }

        enumerator: "DISABLE_TOUCH"

        scalar_value: {

            uint32_t: 9

        }

    }

}