Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e390c1c9 authored by Yu Shan's avatar Yu Shan
Browse files

Remove unnecssary checks in VehiclePropertyStore. 

We use propId and areaId as key to get the current value, so there
is not need to check them against the value to update.

Test: Presubmit
Bug: 307977317
Change-Id: I5e8b3f676c02b4130769615f78a25b3a32b5b6ee
parent c2b9eaa4

automotive/vehicle/aidl/impl/utils/common/src/VehiclePropertyStore.cpp

+2 −3
Original line number Diff line number Diff line
@@ -153,10 +153,9 @@ VhalResult<void> VehiclePropertyStore::writeValue(VehiclePropValuePool::Recyclab 
                propValue->status = oldStatus;

            }



            // areaId and propId must be the same between valueToUpdate and propValue.

            valueUpdated = (valueToUpdate->value != propValue->value ||

                            valueToUpdate->status != propValue->status ||

                            valueToUpdate->prop != propValue->prop ||

                            valueToUpdate->areaId != propValue->areaId);

                            valueToUpdate->status != propValue->status);

        } else if (!updateStatus) {

            propValue->status = VehiclePropertyStatus::AVAILABLE;

        }