Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1e932ea authored by Nick Desaulniers's avatar Nick Desaulniers
Browse files

[hardware][interfaces][camera] fix -Wreorder-init-list 



C++20 will require members in a designated initializer to be in order
unlike C99.

Bug: 139945549
Test: mm
Change-Id: I387d30e993719014da50207c7114b0003b9450c5
Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
parent 0e1efc56

camera/device/3.4/default/ExternalCameraDevice.cpp

+5 −5
Original line number Diff line number Diff line
@@ -755,10 +755,10 @@ void ExternalCameraDevice::getFrameRateList( 
    format->frameRates.clear();



    v4l2_frmivalenum frameInterval{

            .index = 0,

            .pixel_format = format->fourcc,

            .width = format->width,

            .height = format->height,

        .index = 0

    };



    for (frameInterval.index = 0;

camera/device/3.4/default/ExternalCameraDeviceSession.cpp

+1 −3
Original line number Diff line number Diff line
@@ -2412,9 +2412,7 @@ int ExternalCameraDeviceSession::configureV4l2StreamLocked( 
    mV4L2BufferCount = req_buffers.count;

    for (uint32_t i = 0; i < req_buffers.count; i++) {

        v4l2_buffer buffer = {

            .type = V4L2_BUF_TYPE_VIDEO_CAPTURE,

            .index = i,

            .memory = V4L2_MEMORY_MMAP};

                .index = i, .type = V4L2_BUF_TYPE_VIDEO_CAPTURE, .memory = V4L2_MEMORY_MMAP};



        if (TEMP_FAILURE_RETRY(ioctl(mV4l2Fd.get(), VIDIOC_QUERYBUF, &buffer)) < 0) {

            ALOGE("%s: QUERYBUF %d failed: %s", __FUNCTION__, i,  strerror(errno));