Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e16fb74b authored by Tomasz Wasilczyk's avatar Tomasz Wasilczyk Committed by Android (Google) Code Review
Browse files

Merge "Linguistic fixes for broadcastradio 1.1 HAL." into oc-mr1-dev

parents b75bb415 9214894e
Loading
Loading
Loading
Loading
+7 −5
Original line number Original line Diff line number Diff line
@@ -31,14 +31,16 @@ interface IBroadcastRadio extends @1.0::IBroadcastRadio {
     * Fetch image from radio module.
     * Fetch image from radio module.
     *
     *
     * This call is meant to make V1_0::MetaData lightweight - instead of
     * This call is meant to make V1_0::MetaData lightweight - instead of
     * passing image data blob in MetadataType.RAW field, only identifier is
     * passing an image data blob in the MetadataType.RAW field, the HAL
     * passed, so the client may cache images or even not fetch them.
     * implementation only passes the identifier, so the client may cache images
     * or even not fetch them.
     *
     *
     * Identifier may be any arbitrary number - sequential, sha256 prefix,
     * The identifier may be any arbitrary number - sequential, sha256 prefix,
     * or any other unique value selected by the vendor.
     * or any other unique value selected by the vendor.
     *
     *
     * The data should be a valid PNG, JPEG, GIF or BMP file.
     * The data should be a valid PNG, JPEG, GIF or BMP file.
     * Invalid format must be handled gracefully as if the image was missing.
     * Image data with an invalid format must be handled gracefully in the same
     * way as a missing image.
     *
     *
     * The image identifier may become invalid after some time from passing it
     * The image identifier may become invalid after some time from passing it
     * with metadata struct (due to resource cleanup at the HAL implementation).
     * with metadata struct (due to resource cleanup at the HAL implementation).
@@ -56,7 +58,7 @@ interface IBroadcastRadio extends @1.0::IBroadcastRadio {
     * @param id Identifier of an image;
     * @param id Identifier of an image;
     *           value of 0 is reserved and should be treated as invalid image.
     *           value of 0 is reserved and should be treated as invalid image.
     * @return image A binary blob with image data
     * @return image A binary blob with image data
     *               or zero-length vector if identifier doesn't exists.
     *               or a zero-length vector if identifier doesn't exist.
     */
     */
    getImage(int32_t id) generates (vec<uint8_t> image);
    getImage(int32_t id) generates (vec<uint8_t> image);
};
};
+4 −2
Original line number Original line Diff line number Diff line
@@ -19,8 +19,10 @@ package android.hardware.broadcastradio@1.1;
import @1.0::IBroadcastRadioFactory;
import @1.0::IBroadcastRadioFactory;


/**
/**
 * To use 1.1 features you must cast specific interfaces after being returned from 1.0 HAL,
 * To use 1.1 features you must cast specific interfaces returned from the
 * for example V1_1::ITuner::castFrom() after retrieving it from IBroadcastRadio::openTuner().
 * 1.0 HAL. For example V1_0::IBroadcastRadio::openTuner() returns V1_0::ITuner,
 * which can be cast with V1_1::ITuner::castFrom() call.
 *
 * The 1.1 server must always return the 1.1 version of specific interface.
 * The 1.1 server must always return the 1.1 version of specific interface.
 */
 */
interface IBroadcastRadioFactory extends @1.0::IBroadcastRadioFactory {
interface IBroadcastRadioFactory extends @1.0::IBroadcastRadioFactory {