Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0a0a1c2 authored by Eino-Ville Talvala's avatar Eino-Ville Talvala
Browse files

Camera: Clean up TODOs that aren't going to be addressed. 

These TODOs aren't in scope for the wrapper libraries.

Leave the few TODOs that have bugs tracking them, and the ones that
are from autogenerated metadata.

Test: Builds
Bug: 34108979
Change-Id: Ib28467a4fbcfaab4a0809334bc62eabb9290797a
parent 79c636a4

camera/common/1.0/default/CameraMetadata.cpp

+0 −2
Original line number Diff line number Diff line
@@ -508,8 +508,6 @@ status_t CameraMetadata::getTagFromName(const char *name, 
        }

    }



    // TODO: Make above get_camera_metadata_section_from_name ?



    if (section == NULL) {

        return NAME_NOT_FOUND;

    } else {

camera/device/1.0/default/CameraDevice.cpp

+0 −3
Original line number Diff line number Diff line
@@ -183,7 +183,6 @@ int CameraDevice::sDequeueBuffer(struct preview_stream_ops* w, 
}



int CameraDevice::sLockBuffer(struct preview_stream_ops*, buffer_handle_t*) {

    // TODO: make sure lock_buffer is indeed a no-op (and will always be)

    return 0;

}
@@ -585,8 +584,6 @@ Return<void> CameraDevice::getCameraInfo(getCameraInfo_cb _hidl_cb) { 
            cameraInfo.facing = (CameraFacing) info.facing;

            // Device 1.0 does not support external camera facing.

            // The closest approximation would be front camera.

            // TODO: figure out should we override here or let

            //       camera service handle it.

            if (cameraInfo.facing == CameraFacing::EXTERNAL) {

                cameraInfo.facing = CameraFacing::FRONT;

            }

camera/provider/2.4/default/CameraProvider.cpp

+0 −4
Original line number Diff line number Diff line
@@ -461,10 +461,6 @@ Return<void> CameraProvider::getCameraDeviceInterface_V3_x( 
        return Void();

    }



    // TODO: we also need to keep a wp list of all generated devices to notify

    //       devices of device present status change, but then each device might

    //       need a sp<provider> to keep provider alive until all device closed?

    //       Problem: do we have external camera products to test this?

    sp<android::hardware::camera::device::V3_2::implementation::CameraDevice> device =

            new android::hardware::camera::device::V3_2::implementation::CameraDevice(

                    mModule, cameraId, mCameraDeviceNames);