Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d63cd3ff authored by Jooyung Han's avatar Jooyung Han
Browse files

aidl: Suppress warnings on out-array 

out-param arrays are considered harmful since the Java backend requires
them to be correctly allocated at caller site. But the only user of
android.hardware.identity is in C++, we can just ignore them.

Fixes: 179853403
Test: mma in hardware/interfaces/identity
Change-Id: Ib9b7ad895b3827c0888869a5b154696e3aff5624
parent 24c422c4

identity/aidl/aidl_api/android.hardware.identity/current/android/hardware/identity/IIdentityCredential.aidl

+2 −2
Original line number Diff line number Diff line
@@ -43,8 +43,8 @@ interface IIdentityCredential { 
  void startRetrieval(in android.hardware.identity.SecureAccessControlProfile[] accessControlProfiles, in android.hardware.keymaster.HardwareAuthToken authToken, in byte[] itemsRequest, in byte[] signingKeyBlob, in byte[] sessionTranscript, in byte[] readerSignature, in int[] requestCounts);

  void startRetrieveEntryValue(in @utf8InCpp String nameSpace, in @utf8InCpp String name, in int entrySize, in int[] accessControlProfileIds);

  byte[] retrieveEntryValue(in byte[] encryptedContent);

  void finishRetrieval(out byte[] mac, out byte[] deviceNameSpaces);

  android.hardware.identity.Certificate generateSigningKeyPair(out byte[] signingKeyBlob);

  @SuppressWarnings(value={"out-array"}) void finishRetrieval(out byte[] mac, out byte[] deviceNameSpaces);

  @SuppressWarnings(value={"out-array"}) android.hardware.identity.Certificate generateSigningKeyPair(out byte[] signingKeyBlob);

  void setRequestedNamespaces(in android.hardware.identity.RequestNamespace[] requestNamespaces);

  void setVerificationToken(in android.hardware.keymaster.VerificationToken verificationToken);

  byte[] deleteCredentialWithChallenge(in byte[] challenge);

identity/aidl/aidl_api/android.hardware.identity/current/android/hardware/identity/IWritableIdentityCredential.aidl

+1 −1
Original line number Diff line number Diff line
@@ -38,6 +38,6 @@ interface IWritableIdentityCredential { 
  android.hardware.identity.SecureAccessControlProfile addAccessControlProfile(in int id, in android.hardware.identity.Certificate readerCertificate, in boolean userAuthenticationRequired, in long timeoutMillis, in long secureUserId);

  void beginAddEntry(in int[] accessControlProfileIds, in @utf8InCpp String nameSpace, in @utf8InCpp String name, in int entrySize);

  byte[] addEntryValue(in byte[] content);

  void finishAddingEntries(out byte[] credentialData, out byte[] proofOfProvisioningSignature);

  @SuppressWarnings(value={"out-array"}) void finishAddingEntries(out byte[] credentialData, out byte[] proofOfProvisioningSignature);

  void setExpectedProofOfProvisioningSize(in int expectedProofOfProvisioningSize);

}

identity/aidl/android/hardware/identity/IIdentityCredential.aidl

+2 −0
Original line number Diff line number Diff line
@@ -324,6 +324,7 @@ interface IIdentityCredential { 
     *

     * @param out deviceNameSpaces the bytes of DeviceNameSpaces.

     */

    @SuppressWarnings(value={"out-array"})

    void finishRetrieval(out byte[] mac, out byte[] deviceNameSpaces);



    /**
@@ -376,6 +377,7 @@ interface IIdentityCredential { 
     *

     * @return an X.509 certificate for the new signing key, signed by the credential key.

     */

    @SuppressWarnings(value={"out-array"})

    Certificate generateSigningKeyPair(out byte[] signingKeyBlob);



    /**

identity/aidl/android/hardware/identity/IWritableIdentityCredential.aidl

+1 −0
Original line number Diff line number Diff line
@@ -320,6 +320,7 @@ interface IWritableIdentityCredential { 
     *              "accessControlProfiles" : [ * uint ],

     *          }

     */

    @SuppressWarnings(value={"out-array"})

    void finishAddingEntries(out byte[] credentialData,

        out byte[] proofOfProvisioningSignature);