Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3abdfef authored by Wyatt Riley's avatar Wyatt Riley Committed by android-build-merger
Browse files

Merge "Cleaner VTS for wider use" into oc-dr1-dev

am: c127be33

Change-Id: I3929837b71d37bac7ffb3833f360ff8208f79458
parents 5652960d c127be33
Loading
Loading
Loading
Loading
+132 −117
Original line number Diff line number Diff line
@@ -116,6 +116,124 @@ class GnssHalTest : public ::testing::VtsHalHidlTargetTestBase {
    return status;
  }

  /*
   * StartAndGetSingleLocation:
   * Helper function to get one Location and check fields
   *
   * returns  true if a location was successfully generated
   */
  bool StartAndGetSingleLocation(bool checkAccuracies) {
      auto result = gnss_hal_->start();

      EXPECT_TRUE(result.isOk());
      EXPECT_TRUE(result);

      /*
       * GPS signals initially optional for this test, so don't expect fast fix,
       * or no timeout, unless signal is present
       */
      int firstGnssLocationTimeoutSeconds = sAgpsIsPresent ? 15 : 45;
      if (sSignalIsWeak) {
          // allow more time for weak signals
          firstGnssLocationTimeoutSeconds += 30;
      }

      wait(firstGnssLocationTimeoutSeconds);
      if (sAgpsIsPresent) {
          EXPECT_EQ(location_called_count_, 1);
      }
      if (location_called_count_ > 0) {
          CheckLocation(last_location_, checkAccuracies);
          return true;
      }
      return false;
  }

  /*
   * StopAndClearLocations:
   * Helper function to stop locations
   *
   * returns  true if a location was successfully generated
   */
  void StopAndClearLocations() {
      auto result = gnss_hal_->stop();

      EXPECT_TRUE(result.isOk());
      EXPECT_TRUE(result);

      /*
       * Clear notify/waiting counter, allowing up till the timeout after
       * the last reply for final startup messages to arrive (esp. system
       * info.)
       */
      while (wait(TIMEOUT_SEC) == std::cv_status::no_timeout) {
      }
  }

  /*
   * CheckLocation:
   * Helper function to vet Location fields
   */
  void CheckLocation(GnssLocation& location, bool checkAccuracies) {
      EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_LAT_LONG);
      EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_ALTITUDE);
      EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED);
      EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_HORIZONTAL_ACCURACY);
      // New uncertainties available in O must be provided,
      // at least when paired with modern hardware (2017+)
      if (checkAccuracies) {
          EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_VERTICAL_ACCURACY);
          EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED_ACCURACY);
          if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING) {
              EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING_ACCURACY);
          }
      }
      EXPECT_GE(location.latitudeDegrees, -90.0);
      EXPECT_LE(location.latitudeDegrees, 90.0);
      EXPECT_GE(location.longitudeDegrees, -180.0);
      EXPECT_LE(location.longitudeDegrees, 180.0);
      EXPECT_GE(location.altitudeMeters, -1000.0);
      EXPECT_LE(location.altitudeMeters, 30000.0);
      EXPECT_GE(location.speedMetersPerSec, 0.0);
      EXPECT_LE(location.speedMetersPerSec, 5.0);  // VTS tests are stationary.

      // Non-zero speeds must be reported with an associated bearing
      if (location.speedMetersPerSec > 0.0) {
          EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING);
      }

      /*
       * Tolerating some especially high values for accuracy estimate, in case of
       * first fix with especially poor geometry (happens occasionally)
       */
      EXPECT_GT(location.horizontalAccuracyMeters, 0.0);
      EXPECT_LE(location.horizontalAccuracyMeters, 250.0);

      /*
       * Some devices may define bearing as -180 to +180, others as 0 to 360.
       * Both are okay & understandable.
       */
      if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING) {
          EXPECT_GE(location.bearingDegrees, -180.0);
          EXPECT_LE(location.bearingDegrees, 360.0);
      }
      if (location.gnssLocationFlags & GnssLocationFlags::HAS_VERTICAL_ACCURACY) {
          EXPECT_GT(location.verticalAccuracyMeters, 0.0);
          EXPECT_LE(location.verticalAccuracyMeters, 500.0);
      }
      if (location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED_ACCURACY) {
          EXPECT_GT(location.speedAccuracyMetersPerSecond, 0.0);
          EXPECT_LE(location.speedAccuracyMetersPerSecond, 50.0);
      }
      if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING_ACCURACY) {
          EXPECT_GT(location.bearingAccuracyDegrees, 0.0);
          EXPECT_LE(location.bearingAccuracyDegrees, 360.0);
      }

      // Check timestamp > 1.48e12 (47 years in msec - 1970->2017+)
      EXPECT_GT(location.timestamp, 1.48e12);
  }

  /* Callback class for data & Event. */
  class GnssCallback : public IGnssCallback {
   public:
@@ -200,107 +318,6 @@ class GnssHalTest : public ::testing::VtsHalHidlTargetTestBase {
 */
TEST_F(GnssHalTest, SetCallbackCapabilitiesCleanup) {}

/*
 * CheckLocation:
 * Helper function to vet Location fields
 */
void CheckLocation(GnssLocation& location, bool checkAccuracies) {
  EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_LAT_LONG);
  EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_ALTITUDE);
  EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED);
  EXPECT_TRUE(location.gnssLocationFlags &
              GnssLocationFlags::HAS_HORIZONTAL_ACCURACY);
  // New uncertainties available in O must be provided,
  // at least when paired with modern hardware (2017+)
  if (checkAccuracies) {
    EXPECT_TRUE(location.gnssLocationFlags &
                GnssLocationFlags::HAS_VERTICAL_ACCURACY);
    EXPECT_TRUE(location.gnssLocationFlags &
                GnssLocationFlags::HAS_SPEED_ACCURACY);
    if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING) {
      EXPECT_TRUE(location.gnssLocationFlags &
                  GnssLocationFlags::HAS_BEARING_ACCURACY);
    }
  }
  EXPECT_GE(location.latitudeDegrees, -90.0);
  EXPECT_LE(location.latitudeDegrees, 90.0);
  EXPECT_GE(location.longitudeDegrees, -180.0);
  EXPECT_LE(location.longitudeDegrees, 180.0);
  EXPECT_GE(location.altitudeMeters, -1000.0);
  EXPECT_LE(location.altitudeMeters, 30000.0);
  EXPECT_GE(location.speedMetersPerSec, 0.0);
  EXPECT_LE(location.speedMetersPerSec, 5.0);  // VTS tests are stationary.

  // Non-zero speeds must be reported with an associated bearing
  if (location.speedMetersPerSec > 0.0) {
    EXPECT_TRUE(location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING);
  }

  /*
   * Tolerating some especially high values for accuracy estimate, in case of
   * first fix with especially poor geometry (happens occasionally)
   */
  EXPECT_GT(location.horizontalAccuracyMeters, 0.0);
  EXPECT_LE(location.horizontalAccuracyMeters, 250.0);

  /*
   * Some devices may define bearing as -180 to +180, others as 0 to 360.
   * Both are okay & understandable.
   */
  if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING) {
    EXPECT_GE(location.bearingDegrees, -180.0);
    EXPECT_LE(location.bearingDegrees, 360.0);
  }
  if (location.gnssLocationFlags & GnssLocationFlags::HAS_VERTICAL_ACCURACY) {
    EXPECT_GT(location.verticalAccuracyMeters, 0.0);
    EXPECT_LE(location.verticalAccuracyMeters, 500.0);
  }
  if (location.gnssLocationFlags & GnssLocationFlags::HAS_SPEED_ACCURACY) {
    EXPECT_GT(location.speedAccuracyMetersPerSecond, 0.0);
    EXPECT_LE(location.speedAccuracyMetersPerSecond, 50.0);
  }
  if (location.gnssLocationFlags & GnssLocationFlags::HAS_BEARING_ACCURACY) {
    EXPECT_GT(location.bearingAccuracyDegrees, 0.0);
    EXPECT_LE(location.bearingAccuracyDegrees, 360.0);
  }

  // Check timestamp > 1.48e12 (47 years in msec - 1970->2017+)
  EXPECT_GT(location.timestamp, 1.48e12);
}

/*
 * StartAndGetSingleLocation:
 * Helper function to get one Location and check fields
 *
 * returns  true if a location was successfully generated
 */
bool StartAndGetSingleLocation(GnssHalTest* test, bool checkAccuracies) {
  auto result = test->gnss_hal_->start();

  EXPECT_TRUE(result.isOk());
  EXPECT_TRUE(result);

  /*
   * GPS signals initially optional for this test, so don't expect fast fix,
   * or no timeout, unless signal is present
   */
  int firstGnssLocationTimeoutSeconds = sAgpsIsPresent ? 15 : 45;
  if (sSignalIsWeak) {
    // allow more time for weak signals
    firstGnssLocationTimeoutSeconds += 30;
  }

  test->wait(firstGnssLocationTimeoutSeconds);
  if (sAgpsIsPresent) {
    EXPECT_EQ(test->location_called_count_, 1);
  }
  if (test->location_called_count_ > 0) {
    CheckLocation(test->last_location_, checkAccuracies);
    return true;
  }
  return false;
}

/*
 * GetLocation:
 * Turns on location, waits 45 second for at least 5 locations,
@@ -329,21 +346,17 @@ TEST_F(GnssHalTest, GetLocation) {
   * GPS signals initially optional for this test, so don't expect no timeout
   * yet
   */
  bool gotLocation = StartAndGetSingleLocation(this, checkMoreAccuracies);
  bool gotLocation = StartAndGetSingleLocation(checkMoreAccuracies);

  if (gotLocation) {
    for (int i = 1; i < LOCATIONS_TO_CHECK; i++) {
      EXPECT_EQ(std::cv_status::no_timeout,
          wait(LOCATION_TIMEOUT_SUBSEQUENT_SEC));
        EXPECT_EQ(std::cv_status::no_timeout, wait(LOCATION_TIMEOUT_SUBSEQUENT_SEC));
        EXPECT_EQ(location_called_count_, i + 1);
        CheckLocation(last_location_, checkMoreAccuracies);
    }
  }

  result = gnss_hal_->stop();

  ASSERT_TRUE(result.isOk());
  ASSERT_TRUE(result);
  StopAndClearLocations();
}

/*
@@ -368,7 +381,9 @@ TEST_F(GnssHalTest, InjectDelete) {
  ASSERT_TRUE(resultVoid.isOk());

  // Ensure we can get a good location after a bad injection has been deleted
  StartAndGetSingleLocation(this, false);
  StartAndGetSingleLocation(false);

  StopAndClearLocations();
}

/*