Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2e4c074 authored by James Mattis's avatar James Mattis
Browse files

Fix so that dual access points (AP) works. 

Devices that only have dual AP setup without an STA were not working. A
use case for this would be in a car, having a wifi hotspot active while
also projecting to the car head unit from your phone. This was working
but a recent change in CL a3e5b7fc that forced STA to be on wlan0 and AP to start at
wlan1 broke this functionality. This change is to augment the original
CL to keep it's function in place while also taking into
account devices that have dual AP.

Bug: 132268977
Test: Manual boot of hawk device along with testing of tethering and
local only hotspot.

Change-Id: I8da5dd4f0baea1bf0f22d3275e356936a58fb3d1
parent 68fa3708

wifi/1.3/default/wifi_chip.cpp

+12 −3
Original line number Diff line number Diff line
@@ -1435,6 +1435,13 @@ bool WifiChip::isStaApConcurrencyAllowedInCurrentMode() { 
    return canCurrentModeSupportIfaceCombo(req_iface_combo);

}



bool WifiChip::isDualApAllowedInCurrentMode() {

    // Check if we can support atleast 1 STA & 1 AP concurrently.

    std::map<IfaceType, size_t> req_iface_combo;

    req_iface_combo[IfaceType::AP] = 2;

    return canCurrentModeSupportIfaceCombo(req_iface_combo);

}



std::string WifiChip::getFirstActiveWlanIfaceName() {

    if (sta_ifaces_.size() > 0) return sta_ifaces_[0]->getName();

    if (ap_ifaces_.size() > 0) return ap_ifaces_[0]->getName();
@@ -1460,10 +1467,12 @@ std::string WifiChip::allocateApOrStaIfaceName(uint32_t start_idx) { 
}



// AP iface names start with idx 1 for modes supporting

// concurrent STA, else start with idx 0.

// concurrent STA and not dual AP, else start with idx 0.

std::string WifiChip::allocateApIfaceName() {

    return allocateApOrStaIfaceName(

        isStaApConcurrencyAllowedInCurrentMode() ? 1 : 0);

    return allocateApOrStaIfaceName((isStaApConcurrencyAllowedInCurrentMode() &&

                                     !isDualApAllowedInCurrentMode())

                                        ? 1

                                        : 0);

}



// STA iface names start with idx 0.

wifi/1.3/default/wifi_chip.h

+1 −0
Original line number Diff line number Diff line
@@ -237,6 +237,7 @@ class WifiChip : public V1_3::IWifiChip { 
    bool canCurrentModeSupportIfaceOfType(IfaceType requested_type);

    bool isValidModeId(ChipModeId mode_id);

    bool isStaApConcurrencyAllowedInCurrentMode();

    bool isDualApAllowedInCurrentMode();

    std::string getFirstActiveWlanIfaceName();

    std::string allocateApOrStaIfaceName(uint32_t start_idx);

    std::string allocateApIfaceName();