Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf243eba authored by sqian's avatar sqian Committed by Shuo Qian
Browse files

Modify VTS error check so that the error code can be displayed 

- Add AssertionResult in gtest to display logs
- Refactor all the error checks

- Replace INTERNAL_ERR with INVALID_ARGUMENT for 
requestIsimAuthentication

Bug: 63760809
Bug: 65150146
Test: run vts
Change-Id: Iec4bdfd89ccd8d8d8c6e1bd8f720a88d67f23cb3
parent 446e97af

radio/1.0/vts/functional/Android.bp

+4 −1
Original line number Diff line number Diff line
@@ -50,10 +50,13 @@ cc_test { 


cc_library_static {

    name: "RadioVtsTestUtilBase",

    defaults: ["hidl_defaults"],

    defaults: ["VtsHalTargetTestDefaults"],

    srcs : [

        "vts_test_util.cpp"

    ],

    shared_libs: [

        "android.hardware.radio@1.0",

    ],

}



cc_library_headers {

radio/1.0/vts/functional/radio_hidl_hal_cell_broadcast.cpp

+21 −21
Original line number Diff line number Diff line
@@ -74,11 +74,10 @@ TEST_F(RadioHidlTest, setGsmBroadcastConfig) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::INVALID_STATE ||

                    radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::INVALID_ARGUMENTS,

                                      RadioError::INVALID_MODEM_STATE, RadioError::INVALID_STATE},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -95,9 +94,10 @@ TEST_F(RadioHidlTest, getGsmBroadcastConfig) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::INVALID_STATE ||

                    radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::NONE, RadioError::INVALID_MODEM_STATE, RadioError::INVALID_STATE},

            CHECK_GENERAL_ERROR));

    }

}
@@ -122,9 +122,9 @@ TEST_F(RadioHidlTest, setCdmaBroadcastConfig) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::NONE);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::INVALID_MODEM_STATE},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -141,7 +141,8 @@ TEST_F(RadioHidlTest, getCdmaBroadcastConfig) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::NONE);

        ASSERT_TRUE(

            CheckAnyOfErrors(radioRsp->rspInfo.error, {RadioError::NONE}, CHECK_GENERAL_ERROR));

    }

}
@@ -159,9 +160,9 @@ TEST_F(RadioHidlTest, setCdmaBroadcastActivation) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::NONE);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::INVALID_ARGUMENTS},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -179,11 +180,10 @@ TEST_F(RadioHidlTest, setGsmBroadcastActivation) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::INVALID_STATE ||

                    radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::OPERATION_NOT_ALLOWED ||

                    radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::NONE, RadioError::INVALID_ARGUMENTS, RadioError::INVALID_MODEM_STATE,

             RadioError::INVALID_STATE, RadioError::OPERATION_NOT_ALLOWED},

            CHECK_GENERAL_ERROR));

    }

}

radio/1.0/vts/functional/radio_hidl_hal_data.cpp

+19 −20
Original line number Diff line number Diff line
@@ -75,11 +75,11 @@ TEST_F(RadioHidlTest, setupDataCall) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE ||

                    radioRsp->rspInfo.error == RadioError::OP_NOT_ALLOWED_BEFORE_REG_TO_NW ||

                    radioRsp->rspInfo.error == RadioError::OP_NOT_ALLOWED_DURING_VOICE_CALL ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT || CheckOEMError());

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::OP_NOT_ALLOWED_BEFORE_REG_TO_NW,

                                      RadioError::OP_NOT_ALLOWED_DURING_VOICE_CALL,

                                      RadioError::RADIO_NOT_AVAILABLE, RadioError::SIM_ABSENT},

                                     CHECK_OEM_ERROR));

    }

}
@@ -98,10 +98,10 @@ TEST_F(RadioHidlTest, deactivateDataCall) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT || CheckOEMError() ||

                    radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::RADIO_NOT_AVAILABLE,

                                      RadioError::SIM_ABSENT, RadioError::INVALID_CALL_ID},

                                     CHECK_OEM_ERROR));

    }

}
@@ -118,9 +118,9 @@ TEST_F(RadioHidlTest, getDataCallList) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::NONE, RadioError::RADIO_NOT_AVAILABLE, RadioError::SIM_ABSENT}));

    }

}
@@ -160,10 +160,10 @@ TEST_F(RadioHidlTest, setInitialAttachApn) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE ||

                    radioRsp->rspInfo.error == RadioError::SUBSCRIPTION_NOT_AVAILABLE ||

                    CheckOEMError());

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::RADIO_NOT_AVAILABLE,

                                      RadioError::SUBSCRIPTION_NOT_AVAILABLE},

                                     CHECK_OEM_ERROR));

    }

}
@@ -224,9 +224,8 @@ TEST_F(RadioHidlTest, setDataProfile) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT ||

                    radioRsp->rspInfo.error == RadioError::REQUEST_NOT_SUPPORTED);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::RADIO_NOT_AVAILABLE,

                                      RadioError::SIM_ABSENT, RadioError::REQUEST_NOT_SUPPORTED}));

    }

}

radio/1.0/vts/functional/radio_hidl_hal_icc.cpp

+5 −9
Original line number Diff line number Diff line
@@ -310,14 +310,10 @@ TEST_F(RadioHidlTest, supplyNetworkDepersonalization) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::SYSTEM_ERR ||

                    radioRsp->rspInfo.error == RadioError::NO_MEMORY ||

                    radioRsp->rspInfo.error == RadioError::MODEM_ERR ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::INVALID_SIM_STATE ||

                    radioRsp->rspInfo.error == RadioError::PASSWORD_INCORRECT ||

                    radioRsp->rspInfo.error == RadioError::INTERNAL_ERR ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::NONE, RadioError::INVALID_ARGUMENTS, RadioError::INTERNAL_ERR,

             RadioError::INVALID_SIM_STATE, RadioError::MODEM_ERR, RadioError::NO_MEMORY,

             RadioError::PASSWORD_INCORRECT, RadioError::SIM_ABSENT, RadioError::SYSTEM_ERR}));

    }

}

radio/1.0/vts/functional/radio_hidl_hal_ims.cpp

+25 −19
Original line number Diff line number Diff line
@@ -31,7 +31,8 @@ TEST_F(RadioHidlTest, getClir) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::MODEM_ERR);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error, {RadioError::MODEM_ERR},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -70,9 +71,9 @@ TEST_F(RadioHidlTest, getFacilityLockForApp) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::MODEM_ERR);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::INVALID_ARGUMENTS, RadioError::MODEM_ERR},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -94,9 +95,9 @@ TEST_F(RadioHidlTest, setFacilityLockForApp) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::MODEM_ERR);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::INVALID_ARGUMENTS, RadioError::MODEM_ERR},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -116,11 +117,10 @@ TEST_F(RadioHidlTest, setBarringPassword) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() ||

                    radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS ||

                    radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::MODEM_ERR ||

                    radioRsp->rspInfo.error == RadioError::FDN_CHECK_FAILURE);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error,

                                     {RadioError::NONE, RadioError::FDN_CHECK_FAILURE,

                                      RadioError::INVALID_ARGUMENTS, RadioError::MODEM_ERR},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -137,7 +137,8 @@ TEST_F(RadioHidlTest, getClip) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::MODEM_ERR);

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp->rspInfo.error, {RadioError::MODEM_ERR},

                                     CHECK_GENERAL_ERROR));

    }

}
@@ -155,8 +156,8 @@ TEST_F(RadioHidlTest, setSuppServiceNotifications) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::SIM_ABSENT);

        ASSERT_TRUE(

            CheckAnyOfErrors(radioRsp->rspInfo.error, {RadioError::NONE, RadioError::SIM_ABSENT}));

    }

}
@@ -174,7 +175,11 @@ TEST_F(RadioHidlTest, requestIsimAuthentication) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::SIM_ABSENT);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::SIM_ABSENT, RadioError::INVALID_ARGUMENTS RadioError::RADIO_NOT_AVAILABLE,

             RadioError::NO_MEMORY, RadioError::SYSTEM_ERR, RadioError::REQUEST_NOT_SUPPORTED,

             RadioError::CANCELLED}));

    }

}
@@ -191,8 +196,9 @@ TEST_F(RadioHidlTest, getImsRegistrationState) { 
    EXPECT_EQ(serial, radioRsp->rspInfo.serial);



    if (cardStatus.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckGeneralError() || radioRsp->rspInfo.error == RadioError::NONE ||

                    radioRsp->rspInfo.error == RadioError::MODEM_ERR ||

                    radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE);

        ASSERT_TRUE(CheckAnyOfErrors(

            radioRsp->rspInfo.error,

            {RadioError::NONE, RadioError::MODEM_ERR, RadioError::INVALID_MODEM_STATE},

            CHECK_GENERAL_ERROR));

    }

}