Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cbfd8e2d authored by Aaron Tsai's avatar Aaron Tsai
Browse files

Fix emergencyDial tests in VTS 1.6 

 - Change to calling getVoiceRegistrationState_1_6() instead of getVoiceRegistrationState().
 - Fix incorrect voice registration state value

Bug: 187488263
Test: atest VtsHalRadioV1_6TargetTest
Change-Id: Iba5dcef20683bc6dca00b1c49899cfec5e1aac03
parent cad54032

radio/1.6/vts/functional/radio_hidl_hal_api.cpp

+3 −3
Original line number Original line Diff line number Diff line
@@ -585,7 +585,7 @@ TEST_P(RadioHidlTest_v1_6, emergencyDial_1_6) { 
    // or Emergency_Only.

    // or Emergency_Only.

    if (isDsDsEnabled() || isTsTsEnabled()) {

    if (isDsDsEnabled() || isTsTsEnabled()) {

        serial = GetRandomSerialNumber();

        serial = GetRandomSerialNumber();

        radio_v1_6->getVoiceRegistrationState(serial);

        radio_v1_6->getVoiceRegistrationState_1_6(serial);

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {
@@ -639,7 +639,7 @@ TEST_P(RadioHidlTest_v1_6, emergencyDial_1_6_withServices) { 
    // or Emergency_Only.

    // or Emergency_Only.

    if (isDsDsEnabled() || isTsTsEnabled()) {

    if (isDsDsEnabled() || isTsTsEnabled()) {

        serial = GetRandomSerialNumber();

        serial = GetRandomSerialNumber();

        radio_v1_6->getVoiceRegistrationState(serial);

        radio_v1_6->getVoiceRegistrationState_1_6(serial);

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {
@@ -692,7 +692,7 @@ TEST_P(RadioHidlTest_v1_6, emergencyDial_1_6_withEmergencyRouting) { 
    // or Emergency_Only.

    // or Emergency_Only.

    if (isDsDsEnabled() || isTsTsEnabled()) {

    if (isDsDsEnabled() || isTsTsEnabled()) {

        serial = GetRandomSerialNumber();

        serial = GetRandomSerialNumber();

        radio_v1_6->getVoiceRegistrationState(serial);

        radio_v1_6->getVoiceRegistrationState_1_6(serial);

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        EXPECT_EQ(std::cv_status::no_timeout, wait());

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

        if (isVoiceEmergencyOnly(radioRsp_v1_6->voiceRegResp.regState) ||

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {

            isVoiceInService(radioRsp_v1_6->voiceRegResp.regState)) {

radio/1.6/vts/functional/radio_response.cpp

+2 −1
Original line number Original line Diff line number Diff line
@@ -1209,8 +1209,9 @@ Return<void> RadioResponse_v1_6::getSystemSelectionChannelsResponse( 




Return<void> RadioResponse_v1_6::getVoiceRegistrationStateResponse_1_6(

Return<void> RadioResponse_v1_6::getVoiceRegistrationStateResponse_1_6(

        const ::android::hardware::radio::V1_6::RadioResponseInfo& info,

        const ::android::hardware::radio::V1_6::RadioResponseInfo& info,

        const ::android::hardware::radio::V1_6::RegStateResult& /*regResponse*/) {

        const ::android::hardware::radio::V1_6::RegStateResult& regResponse) {

    rspInfo = info;

    rspInfo = info;

    voiceRegResp.regState = regResponse.regState;

    parent_v1_6.notify(info.serial);

    parent_v1_6.notify(info.serial);

    return Void();

    return Void();

}

}