Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7585d9d authored by ramindani's avatar ramindani Committed by Ram Indani
Browse files

Set isOpaque For BlendMode::None 

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 216205298
BUG: 219576457

Change-Id: I479d8367e5abf8893b94ac64b7149a2f0e4cf75b
parent d354a980

graphics/composer/aidl/vts/ReadbackVts.cpp

+1 −0
Original line number Diff line number Diff line
@@ -76,6 +76,7 @@ LayerSettings TestLayer::toRenderEngineLayerSettings() { 


    layerSettings.alpha = ::android::half(mAlpha);

    layerSettings.disableBlending = mBlendMode == BlendMode::NONE;

    layerSettings.source.buffer.isOpaque = mBlendMode == BlendMode::NONE;

    layerSettings.geometry.boundaries = ::android::FloatRect(

            static_cast<float>(mDisplayFrame.left), static_cast<float>(mDisplayFrame.top),

            static_cast<float>(mDisplayFrame.right), static_cast<float>(mDisplayFrame.bottom));

graphics/composer/aidl/vts/VtsHalGraphicsComposer3_ReadbackTest.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1132,8 +1132,8 @@ class GraphicsBlendModeCompositionTest 
    Color mBackgroundColor;

    Color mTopLayerColor;

};

// TODO(b/219576457) Enable tests once we have fixed the bug on composer.

TEST_P(GraphicsBlendModeCompositionTest, DISABLED_None) {



TEST_P(GraphicsBlendModeCompositionTest, None) {

    for (ColorMode mode : mTestColorModes) {

        EXPECT_TRUE(mComposerClient

                            ->setColorMode(getPrimaryDisplayId(), mode, RenderIntent::COLORIMETRIC)