Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc00ee0a authored by Jack Yu's avatar Jack Yu Committed by Automerger Merge Worker
Browse files

Merge "Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed." am: 86bc1500 

Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2471285



Change-Id: I27cceacc1f5bb58d2348cc484ba0d3ce488bb38f
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 7062a484 86bc1500

radio/1.5/vts/functional/radio_hidl_hal_api.cpp

+10 −5
Original line number Diff line number Diff line
@@ -595,12 +595,17 @@ TEST_P(RadioHidlTest_v1_5, startNetworkScan) { 
    if (cardStatus.base.base.base.cardState == CardState::ABSENT) {

        ASSERT_TRUE(CheckAnyOfErrors(radioRsp_v1_5->rspInfo.error, {RadioError::SIM_ABSENT}));

    } else if (cardStatus.base.base.base.cardState == CardState::PRESENT) {

        // OPERATION_NOT_ALLOWED should not be allowed; however, some vendors do

        // not support the required manual GSM search functionality. This is

        // tracked in b/112206766. Modems have "GSM" rat scan need to

        // Modems have "GSM" rat scan need to

        // support scanning requests combined with some parameters.

        if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM)) {

            ASSERT_TRUE(CheckAnyOfErrors(radioRsp_v1_5->rspInfo.error,

                                         {RadioError::NONE, RadioError::OPERATION_NOT_ALLOWED}));

        } else {

            ASSERT_TRUE(CheckAnyOfErrors(

                    radioRsp_v1_5->rspInfo.error,

                    {RadioError::NONE, RadioError::OPERATION_NOT_ALLOWED,

                     RadioError::REQUEST_NOT_SUPPORTED, RadioError::INVALID_ARGUMENTS}));

        }

    }



    if (radioRsp_v1_5->rspInfo.error == RadioError::NONE) {

radio/aidl/vts/radio_network_test.cpp

+9 −2
Original line number Diff line number Diff line
@@ -862,8 +862,15 @@ TEST_P(RadioNetworkTest, startNetworkScan) { 
        // not support the required manual GSM search functionality. This is

        // tracked in b/112206766. Modems have "GSM" rat scan need to

        // support scanning requests combined with some parameters.

        if (deviceSupportsFeature(FEATURE_TELEPHONY_GSM)) {

            ASSERT_TRUE(CheckAnyOfErrors(radioRsp_network->rspInfo.error,

                                         {RadioError::NONE, RadioError::OPERATION_NOT_ALLOWED}));

        } else {

            ASSERT_TRUE(CheckAnyOfErrors(

                    radioRsp_network->rspInfo.error,

                    {RadioError::NONE, RadioError::OPERATION_NOT_ALLOWED, RadioError::NONE,

                     RadioError::INVALID_ARGUMENTS, RadioError::REQUEST_NOT_SUPPORTED}));

        }

    }



    if (radioRsp_network->rspInfo.error == RadioError::NONE) {