Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bae23366 authored by Mikhail Naganov's avatar Mikhail Naganov
Browse files

HidlUtils: remove temporary conversion functions 

Remove temporary conversion functions and update
the code that was using them.

Bug: 142480271
Test: m
Change-Id: Idf36dbac398efbc03bd6da68c79f6fb1ddc24e9c
Merged-In: Idf36dbac398efbc03bd6da68c79f6fb1ddc24e9c
parent f363ed4f

audio/common/all-versions/default/HidlUtils.h

+2 −14
Original line number Diff line number Diff line
@@ -76,19 +76,7 @@ struct HidlUtils { 
                                         const char* halDeviceAddress, DeviceAddress* device);

#endif



#if MAJOR_VERSION <= 6

    // Temporary versions for compatibility with forks of the default implementation.

    // Will be removed, do not use!

    static status_t audioConfigFromHal(const audio_config_t& halConfig, AudioConfig* config) {

        return audioConfigFromHal(halConfig, false /*isInput--ignored*/, config);

    }

    static std::unique_ptr<audio_port_config[]> audioPortConfigsToHal(

            const hidl_vec<AudioPortConfig>& configs) {

        std::unique_ptr<audio_port_config[]> halConfigs;

        (void)audioPortConfigsToHal(configs, &halConfigs);

        return halConfigs;

    }

#else  // V7 and above

#if MAJOR_VERSION >= 7

    static status_t audioChannelMaskFromHal(audio_channel_mask_t halChannelMask, bool isInput,

                                            AudioChannelMask* channelMask);

    static status_t audioChannelMasksFromHal(const std::vector<std::string>& halChannelMasks,
@@ -138,7 +126,7 @@ struct HidlUtils { 
                                               struct audio_port_config_device_ext* device,

                                               struct audio_port_config_mix_ext* mix,

                                               struct audio_port_config_session_ext* session);

#endif

#endif  // MAJOR_VERSION >= 7



    // V4 and below have DeviceAddress defined in the 'core' interface.

    // To avoid duplicating code, the implementations of deviceAddressTo/FromHal